From: Matthew Wilcox <matthew@wil.cx>
To: Bodo Eggert <7eggert@gmx.de>
Cc: Manish Katiyar <mkatiyar@gmail.com>,
Marco Stornelli <marco.stornelli@coritel.it>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfs: added better file aio_read aio_write operations presence check
Date: Tue, 16 Sep 2008 09:41:37 -0600 [thread overview]
Message-ID: <20080916154137.GB2119@parisc-linux.org> (raw)
In-Reply-To: <E1Kfcb3-0003ra-Q7@be1.7eggert.dyndns.org>
On Tue, Sep 16, 2008 at 05:36:09PM +0200, Bodo Eggert wrote:
> Why can't the file system registration code set filp->f_op->aio_read to
> generic_file_aio_read?
const struct file_operations *f_op;
Having said that, BUILD_BUG_ON(!f_op->aio_read) is fine by me ... make
the filesystem writer put it in without slowing down anyone at runtime.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-09-16 15:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bcF2N-29W-1@gated-at.bofh.it>
[not found] ` <bcGBv-4eJ-1@gated-at.bofh.it>
2008-09-16 15:36 ` [PATCH] vfs: added better file aio_read aio_write operations presence check Bodo Eggert
2008-09-16 15:41 ` Matthew Wilcox [this message]
2008-09-16 9:29 Marco Stornelli
2008-09-16 11:03 ` Manish Katiyar
2008-09-16 11:13 ` Marco Stornelli
2008-09-16 11:31 ` Manish Katiyar
2008-09-16 16:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080916154137.GB2119@parisc-linux.org \
--to=matthew@wil.cx \
--cc=7eggert@gmx.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@coritel.it \
--cc=mkatiyar@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.