All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, akpm@linux-foundation.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] blkdev.h: fix warnings when CONFIG_BLOCK=n
Date: Tue, 16 Sep 2008 23:50:40 +0200	[thread overview]
Message-ID: <20080916215039.GZ20055@kernel.dk> (raw)
In-Reply-To: <Pine.LNX.4.64.0809161226230.32267@shark.he.net>

On Tue, Sep 16 2008, Randy.Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix lots of build warnings when CONFIG_BLOCK=n:
> 
> linux-next-20080916/include/linux/blkdev.h:1093: warning: 'struct block_device' declared inside parameter list
> linux-next-20080916/include/linux/blkdev.h:1093: warning: its scope is only this definition or declaration, which is probably not what you want
> linux-next-20080916/include/linux/blkdev.h:1097: warning: 'struct gendisk' declared inside parameter list
> linux-next-20080916/include/linux/blkdev.h:1105: warning: 'struct hd_geometry' declared inside parameter list
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  include/linux/blkdev.h |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> --- linux-next-20080916.orig/include/linux/blkdev.h
> +++ linux-next-20080916/include/linux/blkdev.h
> @@ -1089,6 +1089,10 @@ static inline long nr_blockdev_pages(voi
>  
>  #endif /* CONFIG_BLOCK */
>  
> +struct block_device;
> +struct gendisk;
> +struct hd_geometry;
> +
>  extern int __blkdev_driver_ioctl(struct block_device *, fmode_t, unsigned int,
>  				 unsigned long);
>  

Not sure which tree that build problem came from, it isn't from the
block git tree.

-- 
Jens Axboe

  reply	other threads:[~2008-09-16 21:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-16  7:34 linux-next: Tree for September 16 Stephen Rothwell
2008-09-16 18:00 ` Takashi Iwai
2008-09-16 18:50 ` linux-next: Tree for September 16 (cpustr.h) Randy.Dunlap
2008-09-16 20:48   ` H. Peter Anvin
2008-09-16 20:48     ` H. Peter Anvin
2008-09-19 20:28     ` Randy Dunlap
2008-09-19 20:28       ` Randy Dunlap
2008-09-16 19:29 ` [PATCH -next] blkdev.h: fix warnings when CONFIG_BLOCK=n Randy.Dunlap
2008-09-16 21:50   ` Jens Axboe [this message]
2008-09-16 22:16     ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080916215039.GZ20055@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.