Re: [PATCH] linux/inotify.h: do not include <linux/fcntl.h> in userspace

["Kirill A. Shutemov" <kirill@shutemov.name>]

[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]

On Wed, Sep 17, 2008 at 12:32:40PM +0300, Kirill A. Shutemov wrote:
> On Tue, Sep 16, 2008 at 07:09:02PM +0300, Adrian Bunk wrote:
> > On Tue, Sep 16, 2008 at 07:10:25AM -0700, Ulrich Drepper wrote:
> > > Kirill A. Shutemov wrote:
> > > >> What is the error message?
> > > > 
> > > > /usr/include/asm-generic/fcntl.h:117: error: redefinition of 'struct
> > > > flock'
> > > 
> > > And?  None of these programs should use <linux/inotify.h>.  There has
> > > for the longest time been a <sys/inotify.h> header which doesn't need
> > > any kernel headers.  In fact, <linux/inotify.h> should not be exported.
> > 
> > Even if userspace applications shouldn't use it directly this doesn't 
> > sound right:
> > 
> > We shouldn't force all libc implementations to copy the contents into a 
> > private header.
> 
> glibc and dietlibc provide <sys/inotify.h>. newlib and uclibc don't. klibc
> provides <sys/inotify.h> but it depends on <linux/inotify.h>

Oh.. Sorry. uclibc provides <sys/inotify.h>.

So unexporting <linux/inotify.h> breaks only klibc.

-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + ALT Linux Team, http://www.altlinux.com/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]