From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [Bug #11308] tbench regression on each kernel release from 2.6.22 -> 2.6.28 Date: Wed, 17 Sep 2008 12:40:44 +0200 Message-ID: <20080917104044.GC18764@elte.hu> References: <48CAE7A0.8000004@linux-foundation.org> <1221306287.5213.111.camel@marge.simson.net> <48CD1D25.9080301@linux-foundation.org> <1221421907.4597.24.camel@marge.simson.net> <1221475440.4784.39.camel@marge.simson.net> <1221568105.5020.17.camel@marge.simson.net> <1221626391.5043.13.camel@marge.simson.net> <1221627676.5125.3.camel@marge.simson.net> Mime-Version: 1.0 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1221627676.5125.3.camel-YqMYhexLQo1vAv1Ojkdn7Q@public.gmane.org> Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="iso-8859-1" To: Mike Galbraith Cc: Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Christoph Lameter , "Rafael J. Wysocki" , LKML , kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org * Mike Galbraith wrote: > On Wed, 2008-09-17 at 06:40 +0200, Mike Galbraith wrote: > > On Tue, 2008-09-16 at 17:07 +0300, Ilpo J=E4rvinen wrote: >=20 > > > One additional sanity check could be to rebase security 6f0f0fd49= 63 on top=20 > > > of the c142bda458a and then see if bisection among those security= commits=20 > > > on top yields to the the same result... Though I doubt it can cha= nge much=20 > > > because there was not that much relevant non-security things in t= he merge=20 > > > in question. > >=20 > > I'm not a master of git-foo, so that is not an option. However, a = dinky > > bisection c142bda4..847106f very clearly says... > >=20 > > marge:..kernel/linux-2.6.27.git # git bisect bad > > 6f0f0fd496333777d53daff21a4e3b28c4d03a6d is first bad commit > > commit 6f0f0fd496333777d53daff21a4e3b28c4d03a6d > > Author: James Morris > > Date: Thu Jul 10 17:02:07 2008 +0900 > >=20 > > security: remove register_security hook > >=20 > > The register security hook is no longer required, as the capabi= lity > > module is always registered. LSMs wishing to stack capability = as > > a secondary module should do so explicitly. > >=20 > > Signed-off-by: James Morris > > Acked-by: Stephen Smalley > > Acked-by: Greg Kroah-Hartman > >=20 > > :040000 040000 0177ef46d305e51e27bfcc4350a40577f8ba8d3d 64b64c10a42= 4df4539653a8ee34f1a2329300931 M include > > :040000 040000 e318891e514de674fd064f6bfad70d5633b1aff1 0dbb38d5aa7= fc3e4b2e09dc65796ce7cd5faeb26 M security >=20 > Which is high grade horse-pookey. perhaps re-test commit 6f0f0fd49 and its parent commit, 93cbace7a0. It looks like a potentially bogus bisection result, but _maybe_ it has=20 relevance: changes the size of "struct security_operations", which coul= d=20 have alignment and layout effects on all sorts of kernel variables,=20 kmalloc sizes, etc. Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754066AbYIQKlU (ORCPT ); Wed, 17 Sep 2008 06:41:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752361AbYIQKlH (ORCPT ); Wed, 17 Sep 2008 06:41:07 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:57664 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752172AbYIQKlE (ORCPT ); Wed, 17 Sep 2008 06:41:04 -0400 Date: Wed, 17 Sep 2008 12:40:44 +0200 From: Ingo Molnar To: Mike Galbraith Cc: Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Christoph Lameter , "Rafael J. Wysocki" , LKML , kernel-testers@vger.kernel.org Subject: Re: [Bug #11308] tbench regression on each kernel release from 2.6.22 -> 2.6.28 Message-ID: <20080917104044.GC18764@elte.hu> References: <48CAE7A0.8000004@linux-foundation.org> <1221306287.5213.111.camel@marge.simson.net> <48CD1D25.9080301@linux-foundation.org> <1221421907.4597.24.camel@marge.simson.net> <1221475440.4784.39.camel@marge.simson.net> <1221568105.5020.17.camel@marge.simson.net> <1221626391.5043.13.camel@marge.simson.net> <1221627676.5125.3.camel@marge.simson.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1221627676.5125.3.camel@marge.simson.net> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Mike Galbraith wrote: > On Wed, 2008-09-17 at 06:40 +0200, Mike Galbraith wrote: > > On Tue, 2008-09-16 at 17:07 +0300, Ilpo Järvinen wrote: > > > > One additional sanity check could be to rebase security 6f0f0fd4963 on top > > > of the c142bda458a and then see if bisection among those security commits > > > on top yields to the the same result... Though I doubt it can change much > > > because there was not that much relevant non-security things in the merge > > > in question. > > > > I'm not a master of git-foo, so that is not an option. However, a dinky > > bisection c142bda4..847106f very clearly says... > > > > marge:..kernel/linux-2.6.27.git # git bisect bad > > 6f0f0fd496333777d53daff21a4e3b28c4d03a6d is first bad commit > > commit 6f0f0fd496333777d53daff21a4e3b28c4d03a6d > > Author: James Morris > > Date: Thu Jul 10 17:02:07 2008 +0900 > > > > security: remove register_security hook > > > > The register security hook is no longer required, as the capability > > module is always registered. LSMs wishing to stack capability as > > a secondary module should do so explicitly. > > > > Signed-off-by: James Morris > > Acked-by: Stephen Smalley > > Acked-by: Greg Kroah-Hartman > > > > :040000 040000 0177ef46d305e51e27bfcc4350a40577f8ba8d3d 64b64c10a424df4539653a8ee34f1a2329300931 M include > > :040000 040000 e318891e514de674fd064f6bfad70d5633b1aff1 0dbb38d5aa7fc3e4b2e09dc65796ce7cd5faeb26 M security > > Which is high grade horse-pookey. perhaps re-test commit 6f0f0fd49 and its parent commit, 93cbace7a0. It looks like a potentially bogus bisection result, but _maybe_ it has relevance: changes the size of "struct security_operations", which could have alignment and layout effects on all sorts of kernel variables, kmalloc sizes, etc. Ingo