From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] usb-serial: Fix memory overruns with usb serial emulation
Date: Wed, 17 Sep 2008 11:18:42 +0100 [thread overview]
Message-ID: <200809171118.42802.paul@codesourcery.com> (raw)
In-Reply-To: <48D08F06.2070905@windriver.com>
On Wednesday 17 September 2008, Jason Wessel wrote:
> * Fix a memory overrun
> recv_buf[RECV_BUF + 1];
> This has to be + 1 because RECV_BUF is used for memcpy computations
> in usb_serial_read() such that an extra byte is 0..RECV_BUF bytes
> are used.
I think this is wrong. I can't see any way this code could overflow.
Paul
next prev parent reply other threads:[~2008-09-17 10:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-17 5:00 [Qemu-devel] [PATCH] usb-serial: Fix memory overruns with usb serial emulation Jason Wessel
2008-09-17 10:18 ` Paul Brook [this message]
2008-09-17 10:38 ` Paul Brook
2008-09-17 11:54 ` Jason Wessel
2008-09-17 20:01 ` Samuel Thibault
2008-09-17 22:04 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809171118.42802.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.