From: Peter Oruba <peter.oruba@amd.com>
To: Dmitry Adamushko <dmitry.adamushko@gmail.com>,
Ingo Molnar <mingo@elte.hu>
Cc: Tigran Aivazian <tigran@aivazian.fsnet.co.uk>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86, microcode rework, v2, renaming
Date: Mon, 17 Sep 2001 00:00:00 +0200 [thread overview]
Message-ID: <200809171324.m8HDO4Kr003664@elemente.amd.com> (raw)
In-Reply-To: <b647ffbd0809161443o5b7bf71aw59853d8d6086ee2d@mail.gmail.com>
Renaming based on patch from Dmitry Adamushko.
Made code more readable by renaming define and variables related
to microcode _container_file_ header to make it distinguishable from
microcode _patch_ header.
Signed-off-by: Peter Oruba <peter.oruba@amd.com>
---
arch/x86/kernel/microcode_amd.c | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c
index 48aec9f..8d97840 100644
--- a/arch/x86/kernel/microcode_amd.c
+++ b/arch/x86/kernel/microcode_amd.c
@@ -274,12 +274,12 @@ static void * get_next_ucode(u8 *buf, unsigned int size,
static int install_equiv_cpu_table(u8 *buf,
int (*get_ucode_data)(void *, const void *, size_t))
{
-#define UCODE_HEADER_SIZE 12
- u8 *hdr[UCODE_HEADER_SIZE];
- unsigned int *buf_pos = (unsigned int *)hdr;
+#define UCODE_CONTAINER_HEADER_SIZE 12
+ u8 *container_hdr[UCODE_CONTAINER_HEADER_SIZE];
+ unsigned int *buf_pos = (unsigned int *)container_hdr;
unsigned long size;
- if (get_ucode_data(&hdr, buf, UCODE_HEADER_SIZE))
+ if (get_ucode_data(&container_hdr, buf, UCODE_CONTAINER_HEADER_SIZE))
return 0;
size = buf_pos[2];
@@ -296,14 +296,14 @@ static int install_equiv_cpu_table(u8 *buf,
return 0;
}
- buf += UCODE_HEADER_SIZE;
+ buf += UCODE_CONTAINER_HEADER_SIZE;
if (get_ucode_data(equiv_cpu_table, buf, size)) {
vfree(equiv_cpu_table);
return 0;
}
- return size + UCODE_HEADER_SIZE; /* add header length */
-#undef UCODE_HEADER_SIZE
+ return size + UCODE_CONTAINER_HEADER_SIZE; /* add header length */
+#undef UCODE_CONTAINER_HEADER_SIZE
}
static void free_equiv_cpu_table(void)
--
1.5.4.1
next prev parent reply other threads:[~2008-09-17 14:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-14 9:14 [x86-tip, patch] rework of the microcode splitup Dmitry Adamushko
2008-09-14 9:18 ` Dmitry Adamushko
2008-09-14 12:55 ` Ingo Molnar
2008-09-16 21:43 ` Dmitry Adamushko
2001-09-16 22:00 ` Peter Oruba [this message]
2008-09-17 13:39 ` [PATCH] x86, microcode rework, v2, renaming cont Peter Oruba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809171324.m8HDO4Kr003664@elemente.amd.com \
--to=peter.oruba@amd.com \
--cc=dmitry.adamushko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tigran@aivazian.fsnet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.