From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752924AbYIQOmN (ORCPT ); Wed, 17 Sep 2008 10:42:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752352AbYIQOl6 (ORCPT ); Wed, 17 Sep 2008 10:41:58 -0400 Received: from lazybastard.de ([212.112.238.170]:34802 "EHLO longford.logfs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751634AbYIQOl5 (ORCPT ); Wed, 17 Sep 2008 10:41:57 -0400 Date: Wed, 17 Sep 2008 16:41:47 +0200 From: =?utf-8?B?SsO2cm4=?= Engel To: Ryusuke Konishi Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Seiji Kihara , Yoshiji Amagai Subject: Re: [PATCH 25/27] nilfs2: block cache for garbage collection Message-ID: <20080917144146.GD8750@logfs.org> References: <1221419304-18572-17-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-18-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-19-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-20-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-21-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-22-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-23-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-24-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-25-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-26-git-send-email-konishi.ryusuke@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1221419304-18572-26-git-send-email-konishi.ryusuke@lab.ntt.co.jp> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 September 2008 04:08:22 +0900, Ryusuke Konishi wrote: > > This adds the cache of on-disk blocks to be moved in garbage > collection. The disk blocks are held with dummy inodes (called > gcinodes), and this file provides lookup function of the dummy inodes, > and their buffer read function. Nice explanation. Can you add it to the comment header at the top of the file? Unlike the GPL preample, it actually helps non-lawyers. ;) Using dummy inodes is... unusual. Why can you not use the actual inodes those blocks belong to? Or alternatively a single inode that simply covers the complete physical device? Jörn -- All models are wrong. Some models are useful. -- George Box From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?SsO2cm4=?= Engel Subject: Re: [PATCH 25/27] nilfs2: block cache for garbage collection Date: Wed, 17 Sep 2008 16:41:47 +0200 Message-ID: <20080917144146.GD8750@logfs.org> References: <1221419304-18572-17-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-18-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-19-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-20-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-21-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-22-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-23-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-24-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-25-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-26-git-send-email-konishi.ryusuke@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Seiji Kihara , Yoshiji Amagai To: Ryusuke Konishi Return-path: Received: from lazybastard.de ([212.112.238.170]:34802 "EHLO longford.logfs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751634AbYIQOl5 (ORCPT ); Wed, 17 Sep 2008 10:41:57 -0400 Content-Disposition: inline In-Reply-To: <1221419304-18572-26-git-send-email-konishi.ryusuke@lab.ntt.co.jp> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, 15 September 2008 04:08:22 +0900, Ryusuke Konishi wrote: >=20 > This adds the cache of on-disk blocks to be moved in garbage > collection. The disk blocks are held with dummy inodes (called > gcinodes), and this file provides lookup function of the dummy inodes= , > and their buffer read function. Nice explanation. Can you add it to the comment header at the top of the file? Unlike the GPL preample, it actually helps non-lawyers. ;) Using dummy inodes is... unusual. Why can you not use the actual inode= s those blocks belong to? Or alternatively a single inode that simply covers the complete physical device? J=C3=B6rn --=20 All models are wrong. Some models are useful. -- George Box -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html