Re: [Qemu-devel] [PATCH] add futimesat syscall

[Riku Voipio <riku.voipio@iki.fi>]

On Thu, Sep 18, 2008 at 09:23:20AM +0200, Laurent Desnogues wrote:
> On Thu, Sep 18, 2008 at 8:30 AM, Riku Voipio <riku.voipio@iki.fi> wrote:
> > On Thu, Sep 18, 2008 at 01:54:21AM +0200, andrzej zaborowski wrote:

> >> http://lists.gnu.org/archive/html/qemu-devel/2008-09/msg00439.html ,
> >> it looks cleaner to me.

> > Kirill's patch looks good to me.

> There's a functional difference between Kirill's patch and yours:

> Kirill +            ret = get_errno(futimesat(arg1, p, tvp));
> you   +                ret = get_errno(sys_futimesat(arg1, path(p), tv));

The sbox patch defines sys_futimesat earlier in the file, presumably to
deal with supporting a stone-age version of libc/kernel headers.
path() is related to interp_prefix. The old utimes handlers don't use
path() either, and it's unlikely that any library-loading routine uses
futimes(). Thus, I believe Kirill's version is more correct.

That said, path() should probably renamed to something more obvious
(interp_path() ?), or path mangling could be made more generic (allowing
things like chroot() emulation).

-- 
"rm -rf" only sounds scary if you don't have backups