Re: [RFC] b43: A patch for control of the radio LED using rfkill

[Michael Buesch <mb@bu3sch.de>]

On Thursday 18 September 2008 16:21:33 Henrique de Moraes Holschuh wrote:
> The problem is that it really boils down to something like this:
> 
> static inline enum rfkill_state translate_to_rfkill_state(
> 		const bool is_any_hw_rfkill_line_active_RIGHT_NOW,
> 		const bool is_any_sw_rfkill_line_active_RIGHT_NOW) {
> 
> 	if (is_any_hw_rfkill_line_active_RIGHT_NOW)
> 		return RFKILL_STATE_HARD_BLOCKED;
> 	else if (is_any_sw_rfkill_line_active_RIGHT_NOW)
> 		return RFKILL_STATE_SOFT_BLOCKED;
> 	else
> 		return RFKILL_STATE_UNBLOCKED;
> }
> 
> and send that to rfkill_force_state().

I agree with that. We must call that from the paths that change the software
state of the b43 radio and the hardware rfkill state notifiers in the b43 driver.

-- 
Greetings Michael.