From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Felipe Balbi <me@felipebalbi.com>
Cc: linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
David Brownell <david-b@pacbell.net>,
"George G. Davis" <gdavis@mvista.com>,
Wim Van Sebroeck <wim@iguana.be>,
Felipe Balbi <felipe.balbi@nokia.com>
Subject: Re: [PATCH 2/5] watchdog: another ioremap() fix
Date: Fri, 19 Sep 2008 00:06:53 +0100 [thread overview]
Message-ID: <20080918230653.GG14307@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1221776622-22906-3-git-send-email-me@felipebalbi.com>
On Fri, Sep 19, 2008 at 01:23:39AM +0300, Felipe Balbi wrote:
> @@ -359,6 +364,8 @@ fail:
> clk_put(wdev->mpu_wdt_ick);
> if (wdev->mpu_wdt_fck)
> clk_put(wdev->mpu_wdt_fck);
> + if (wdev->base)
> + iounmap(wdev->base);
> kfree(wdev);
> }
> if (mem) {
> @@ -396,6 +403,9 @@ static int omap_wdt_remove(struct platform_device *pdev)
> clk_put(wdev->mpu_wdt_fck);
> wdev->mpu_wdt_fck = NULL;
> }
> + if (wdev->base)
> + iounmap(wdev->base);
> +
For both of these... iounmap on NULL pointers is allowed, so the
test is redundant.
next prev parent reply other threads:[~2008-09-18 23:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 22:23 [RFC] [PATCH 0/5] omap watchdog fixes Felipe Balbi
2008-09-18 22:23 ` [PATCH 1/5] watchdog: sync linux-omap changes Felipe Balbi
2008-09-18 22:23 ` [PATCH 2/5] watchdog: another ioremap() fix Felipe Balbi
2008-09-18 22:23 ` [PATCH 3/5] watchdog: move omap_wdt.h to include/linux/watchdog Felipe Balbi
2008-09-18 22:23 ` [PATCH 4/5] watchdog: cleanup a bit omap_wdt.c Felipe Balbi
2008-09-18 22:23 ` [PATCH 5/5] watchdog: introduce platform_data and remove cpu conditional code Felipe Balbi
2008-09-18 23:20 ` Russell King - ARM Linux
2008-09-18 23:23 ` Felipe Balbi
2008-09-19 7:46 ` Russell King - ARM Linux
2008-09-19 8:15 ` Felipe Balbi
2008-09-18 23:10 ` [PATCH 4/5] watchdog: cleanup a bit omap_wdt.c Russell King - ARM Linux
2008-09-18 23:18 ` Felipe Balbi
2008-09-18 23:10 ` [PATCH 3/5] watchdog: move omap_wdt.h to include/linux/watchdog Russell King - ARM Linux
2008-09-18 23:14 ` Felipe Balbi
2008-09-18 23:06 ` Russell King - ARM Linux [this message]
2008-09-18 23:12 ` [PATCH 2/5] watchdog: another ioremap() fix Felipe Balbi
2008-09-18 23:05 ` [PATCH 1/5] watchdog: sync linux-omap changes Russell King - ARM Linux
2008-09-18 23:11 ` Felipe Balbi
2008-09-18 23:20 ` Russell King - ARM Linux
2008-09-19 8:43 ` Wim Van Sebroeck
-- strict thread matches above, loose matches on Subject: below --
2008-09-19 10:32 [PATCH 0/5] omap watchdog updaes Felipe Balbi
2008-09-19 10:32 ` [PATCH 1/5] watchdog: sync linux-omap changes Felipe Balbi
2008-09-19 10:32 ` [PATCH 2/5] watchdog: another ioremap() fix Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080918230653.GG14307@flint.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=gdavis@mvista.com \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=tony@atomide.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.