Re: [PATCH] remove fullflush and nofullflush in IOMMU generic option

[Joerg Roedel <joerg.roedel@amd.com>]

On Sat, Sep 20, 2008 at 02:40:35AM +0900, FUJITA Tomonori wrote:
> On Fri, 19 Sep 2008 19:30:04 +0200
> Joerg Roedel <joerg.roedel@amd.com> wrote:
> 
> > On Sat, Sep 20, 2008 at 02:09:21AM +0900, FUJITA Tomonori wrote:
> > > 
> > > Please keep it for AMD option for now. Please send a patch to make it
> > > generic to other IOMMU people and give them a chance to discuss on
> > > it.
> > >
> > 
> > Btw, you already agreed with a generic iommu= parameter for lazy IO/TLB
> > flushing"
> > 
> > 
> >  > True. We should merge common parameters across IOMMUs into the
> >  > iommu= parameter some time in the future, I think. It would also be the
> >  > place for the IOMMU size parameter.
> > 
> >  Hmm, now is better than the future? I think that now you can add
> >  something like 'disable_batching_flush' as a common parameter and
> >  change AMD IOMMU to use it.
> > 
> > in http://lkml.org/lkml/2008/9/17/376
> > 
> > And since we already have a iommu=fullflush parameter it makes sense of
> > make it generic.
> 
> I'm not against fullflush but we need to discuss it with other people
> before making the change.

Weird. Just 2 hours ago you wrote:

|http://lkml.org/lkml/2008/9/19/106
|
|For me, adding these boot parameters doesn't make sense.

Anyway, I wrote to the Intel and Calgary developers and asked them for
their opinion. If they have real objections I am the last person NACKing
your original patch in this thread again.
The reason why I queued this patch in AMD IOMMU updates was that I
didn't wanted to implement an option specificly for AMD IOMMU when there
will be a generic one soon. This is double work I prefered to do it
right in the first step. The change does not break anything on Intel and
Calgary.

Joerg

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy