From: agk@sourceware.org <agk@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2/lib/commands toolcontext.c
Date: 19 Sep 2008 18:26:43 -0000 [thread overview]
Message-ID: <20080919182643.12131.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: agk at sourceware.org 2008-09-19 18:26:42
Modified files:
lib/commands : toolcontext.c
Log message:
suppress warning if old value found for now
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/commands/toolcontext.c.diff?cvsroot=lvm2&r1=1.62&r2=1.63
--- LVM2/lib/commands/toolcontext.c 2008/09/19 06:41:58 1.62
+++ LVM2/lib/commands/toolcontext.c 2008/09/19 18:26:41 1.63
@@ -267,6 +267,12 @@
cmd->stripe_filler = find_config_tree_str(cmd,
"activation/missing_stripe_filler",
DEFAULT_STRIPE_FILLER);
+
+ /* FIXME Missing error code checks from the stats, not log_warn?, notify if setting overridden, delay message/check till it is actually used (eg consider if lvm shell - file could appear later after this check)? */
+ if (!strcmp(cmd->stripe_filler, "/dev/ioerror") &&
+ stat(cmd->stripe_filler, &st))
+ cmd->stripe_filler = "error";
+
if (strcmp(cmd->stripe_filler, "error")) {
if (stat(cmd->stripe_filler, &st)) {
log_warn("WARNING: activation/missing_stripe_filler = \"%s\" "
next reply other threads:[~2008-09-19 18:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 18:26 agk [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-12 14:35 LVM2/lib/commands toolcontext.c zkabelac
2012-03-01 21:16 zkabelac
2012-02-08 13:44 zkabelac
2011-09-02 12:38 zkabelac
2011-07-08 17:31 agk
2011-04-29 16:23 agk
2010-12-20 14:34 zkabelac
2010-07-02 10:25 agk
2010-06-01 21:46 wysochanski
2009-07-08 18:12 wysochanski
2009-06-17 20:54 mbroz
2008-04-02 21:31 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080919182643.12131.qmail@sourceware.org \
--to=agk@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.