All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] debug: Introduce a dev_WARN() function
Date: Fri, 19 Sep 2008 21:26:30 -0700	[thread overview]
Message-ID: <20080920042630.GA21501@kroah.com> (raw)
In-Reply-To: <20080919210733.4e9c58e8@infradead.org>

On Fri, Sep 19, 2008 at 09:07:33PM -0700, Arjan van de Ven wrote:
> 
> From: Arjan van de Ven <arjan@linux.intel.com>
> Date: Fri, 19 Sep 2008 21:03:06 -0700
> Subject: [PATCH] debug: Introduce a dev_WARN() function
> 
> in the line of dev_printk(), this patch introduces a dev_WARN() macro,
> that takes a struct device and then a printk format/args set of arguments.
> Unlike dev_printk(), the effect is that of WARN() in that a full warning
> message (including filename/line, module list, versions and a backtrace)
> is printed in addition to the device name and the arguments.

I like the idea, but we already have dev_warn(), so dev_WARN() might be
a bit confusing for people.

Perhaps just documenting it with a docbook tag would suffice?

thanks,

greg k-h

  parent reply	other threads:[~2008-09-20  4:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-20  4:07 [PATCH] debug: Introduce a dev_WARN() function Arjan van de Ven
2008-09-20  4:08 ` [PATCH] debug: use dev_WARN() rather than WARN_ON() in device_pm_add() Arjan van de Ven
2008-09-20  4:26 ` Greg KH [this message]
2008-09-20  6:13   ` [PATCH] debug: Introduce a dev_WARN() function Arjan van de Ven
2008-09-20 22:41     ` Randy Dunlap
2008-09-20 18:11   ` Arjan van de Ven
2008-09-20 20:14     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080920042630.GA21501@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.