From: Ralf Baechle <ralf@linux-mips.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: macro@linux-mips.org, u1@terran.org, linux-mips@linux-mips.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] MIPS checksum fix
Date: Sat, 20 Sep 2008 17:09:14 +0200 [thread overview]
Message-ID: <20080920150914.GA7725@linux-mips.org> (raw)
In-Reply-To: <20080919.230952.128619158.anemo@mba.ocn.ne.jp>
On Fri, Sep 19, 2008 at 11:09:52PM +0900, Atsushi Nemoto wrote:
> I think it would be better splitting bugfix and optimization. This
> code is too complex to do many things at a time, isn't it?
>
> > @@ -53,12 +53,14 @@
> > #define UNIT(unit) ((unit)*NBYTES)
> >
> > #define ADDC(sum,reg) \
> > - .set push; \
> > - .set noat; \
> > ADD sum, reg; \
> > sltu v1, sum, reg; \
> > ADD sum, v1; \
> > - .set pop
>
> Is this required? Just a cleanup?
It papers over potencially important warnings so had to go. I argue the
caller of ADDC should set noat mode, if at all.
Ralf
next prev parent reply other threads:[~2008-09-20 15:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <072748C6-07A9-4167-A8A5-80D0F7D9C784@darkforest.org>
2008-09-17 5:15 ` MIPS checksum bug Bryan Phillippe
2008-09-17 10:40 ` Maciej W. Rozycki
2008-09-17 13:23 ` Atsushi Nemoto
2008-09-17 14:46 ` Maciej W. Rozycki
2008-09-17 15:27 ` Atsushi Nemoto
2008-09-17 18:21 ` Maciej W. Rozycki
2008-09-18 22:07 ` Ralf Baechle
2008-09-19 10:12 ` Maciej W. Rozycki
2008-09-19 11:23 ` Ralf Baechle
2008-09-19 11:47 ` [PATCH] MIPS checksum fix Ralf Baechle
2008-09-19 12:07 ` Ralf Baechle
2008-09-19 12:15 ` Maciej W. Rozycki
2008-09-19 14:09 ` Atsushi Nemoto
2008-09-19 15:02 ` Maciej W. Rozycki
2008-09-20 15:09 ` Ralf Baechle [this message]
2008-09-23 21:52 ` Bryan Phillippe
2008-09-23 22:06 ` Ralf Baechle
2008-09-29 15:28 ` Atsushi Nemoto
2008-09-19 12:26 ` MIPS checksum bug Maciej W. Rozycki
2008-09-19 16:04 ` Bryan Phillippe
2008-09-17 22:52 ` Bryan Phillippe
2008-09-18 16:17 ` Atsushi Nemoto
2008-09-19 1:14 ` Ralf Baechle
2008-09-19 15:43 ` Atsushi Nemoto
2008-09-19 16:09 ` Maciej W. Rozycki
2008-09-19 16:35 ` Thiemo Seufer
2008-09-19 23:18 ` Maciej W. Rozycki
2008-09-20 0:13 ` Ralf Baechle
2008-09-20 13:45 ` Atsushi Nemoto
2008-09-18 4:43 ` Bryan Phillippe
2008-09-18 10:06 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080920150914.GA7725@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=u1@terran.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.