From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] properly show journal checksum/async options
Date: Sat, 20 Sep 2008 18:06:47 -0400 [thread overview]
Message-ID: <20080920220647.GA9088@mit.edu> (raw)
In-Reply-To: <48CD7FC3.4050807@redhat.com>
On Sun, Sep 14, 2008 at 02:18:59PM -0700, Eric Sandeen wrote:
> The journal_checksum option is not being displayed in
> /proc/mounts ... add this to the show_options() output, but
> only if journal_async_commit is not specified, as that enables
> journal_checksum internally.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Acked-by: "Theodore Ts'o" <tytso@mit.edu>
I'll add it to the patch queue, probably combined with a patch to add
journal_sync_commit, and with a patch to make journal_async_commit the
default.
> (Aside: this reminds me that we only show non-default options
> in show_options; has there been any discussion of whether
> these should be defaults?)
Good point, thanks for raising the question.
The reason why journal_async_commit wasn't turned on by default
originally was because e2fsck didn't have support for journal
checksums before e2fsprogs 1.41.0. At this point, it seems like
turning on async_commit is the obvious (and performant) thing to do;
any objections?
- Ted
prev parent reply other threads:[~2008-09-20 23:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-14 21:18 [PATCH] properly show journal checksum/async options Eric Sandeen
2008-09-20 22:06 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080920220647.GA9088@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.