From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH] Add uselib syscall
Date: Sun, 21 Sep 2008 13:59:11 +0100 [thread overview]
Message-ID: <200809211359.11580.paul@codesourcery.com> (raw)
In-Reply-To: <20080919133327.GA19898@kos.to>
> case TARGET_NR_uselib:
> - goto unimplemented;
> + {
> + if(!(p = lock_user_string(arg1))) {
> + ret = -TARGET_EFAULT;
> + goto efault;
> + }
> + ret = get_errno(uselib(path(p)));
> + unlock_user(p, arg1, 0);
> + }
> + break;
I'm pretty sure this is wrong. The last thing we want to be doing is loading a
host library.
Paul
prev parent reply other threads:[~2008-09-21 12:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 13:33 [Qemu-devel] [PATCH] Add uselib syscall Riku Voipio
2008-09-19 14:17 ` Kirill A. Shutemov
2008-09-21 12:59 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809211359.11580.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.