From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH] Add readahead syscall
Date: Sun, 21 Sep 2008 15:09:38 +0100 [thread overview]
Message-ID: <200809211509.39183.paul@codesourcery.com> (raw)
In-Reply-To: <20080921140108.GA20056@localhost.localdomain>
On Sunday 21 September 2008, Kirill A. Shutemov wrote:
> On Sun, Sep 21, 2008 at 02:03:16PM +0100, Paul Brook wrote:
> > > #ifdef TARGET_NR_readahead
> > > case TARGET_NR_readahead:
> > > - goto unimplemented;
> > > + ret = get_errno(readahead(arg1, arg2, arg3));
> > > + break;
> >
> > This is wrong on 32-bit targets, and especially wrong on ARM where there
> > are two variants.
>
> Two variants?
EABI and old-abi.
Paul
next prev parent reply other threads:[~2008-09-21 14:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 13:33 [Qemu-devel] [PATCH] Add readahead syscall Riku Voipio
2008-09-19 14:16 ` Kirill A. Shutemov
2008-09-21 13:03 ` Paul Brook
2008-09-21 14:01 ` Kirill A. Shutemov
2008-09-21 14:09 ` Paul Brook [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-10-01 13:56 [Qemu-devel] [PATCH] Add fadvise64 stubs Kirill A. Shutemov
2008-10-01 13:56 ` [Qemu-devel] [PATCH] Add mincore syscall Kirill A. Shutemov
2008-10-01 13:56 ` [Qemu-devel] [PATCH] Add readahead syscall Kirill A. Shutemov
2008-10-08 18:54 Kirill A. Shutemov
2008-10-13 21:09 ` Aurelien Jarno
2008-10-13 10:10 Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809211509.39183.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=kirill@shutemov.name \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.