From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sun, 21 Sep 2008 22:11:14 +0200 Subject: [U-Boot] ARM & u-boot-next pull request In-Reply-To: References: <20080918150235.GA25419@game.jcrosoft.org> Message-ID: <20080921201114.28943248CD@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Jean-Christophe, in message Guennadi Liakhovetski wrote: > > > Jean-Christophe PLAGNIOL-VILLARD (4): > > Revert "ARM: set GD_FLG_RELOC for boards skipping relocation to RAM" > > ARM: set GD_FLG_RELOC at board init > > This patch's commit doesn't seem right to me. The original patch is: > > From: gnusercn > Date: Tue, 22 Jul 2008 10:35:58 +0800 > Subject: [PATCH] Fix bug: in arch-arm, env_get_char dose not work fine in u-boot 1.3.4-rc1 > > Signed-off-by: gnusercn > > Ok, the patch was corrputed - it had 4 spaces indentation in all lines > instead of TABs, but I don't think this is sufficient reason to commit an > otherwise identical patch with a different author and without the > original Sob. I think, this is a _very_ bad idea. I agree with Guennadi. Please fix this. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de There is a time in the tides of men, Which, taken at its flood, leads on to success. On the other hand, don't count on it. - T. K. Lawson