From: Eric Wong <normalperson@yhbt.net>
To: Junio C Hamano <gitster@pobox.com>, Deskin Miller <deskinm@umich.edu>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 0/1] git-svn: testcase for partial rebuild
Date: Sun, 21 Sep 2008 21:12:34 -0700 [thread overview]
Message-ID: <20080922041128.GA23848@untitled> (raw)
In-Reply-To: <20080921024538.GB2505@riemann.deskinm.fdns.net>
Deskin Miller <deskinm@umich.edu> wrote:
> ---
> On Wed, Sep 17, 2008 at 11:38:04PM -0700, Eric Wong wrote:
> > This seems to break the following test case for me:
> >
> > *** t9107-git-svn-migrate.sh ***
> > * ok 1: setup old-looking metadata
> > * ok 2: git-svn-HEAD is a real HEAD
> > * ok 3: initialize old-style (v0) git svn layout
> > * ok 4: initialize a multi-repository repo
> > * ok 5: multi-fetch works on partial urls + paths
> > * ok 6: migrate --minimize on old inited layout
> > * FAIL 7: .rev_db auto-converted to .rev_map.UUID
> >
> > I haven't had time to diagnose it. Also, can you add a test that
> > demonstrates this functionality (and ensures things keeps working when
> > future work is done on git-svn?)
>
> Thanks for the response; I had a bug in my Perl that my testing hadn't caught.
> Gave me an opportunity to learn how the git testsuites work!
>
> This testcase fails for me when applied to master, and passes with patch 1/1 in
> the series.
Thanks Deskin, this series is
Acked-by: Eric Wong <normalperson@yhbt.net>
Junio: I would apply the patch series in reverse order to not break
tests on potential bisections, however.
--
Eric Wong
next prev parent reply other threads:[~2008-09-22 4:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-17 3:13 [PATCH] git-svn: do a partial rebuild if rev_map is out-of-date Deskin Miller
2008-09-18 6:38 ` Eric Wong
2008-09-21 2:45 ` [PATCH v2 0/1] git-svn: testcase for partial rebuild Deskin Miller
2008-09-22 4:12 ` Eric Wong [this message]
2008-09-21 2:45 ` [PATCH v2 1/1] git-svn: do a partial rebuild if rev_map is out-of-date Deskin Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080922041128.GA23848@untitled \
--to=normalperson@yhbt.net \
--cc=deskinm@umich.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.