From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, Yinghai Lu <yhlu.kernel@gmail.com>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86: do_boot_cpu - add check if we have ESR register
Date: Mon, 22 Sep 2008 13:36:03 +0400 [thread overview]
Message-ID: <20080922093603.GC7663@localhost> (raw)
We should touch ESR register if only we have one.
Check its presence first.
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
CC: Yinghai Lu <yhlu.kernel@gmail.com>
---
Index: linux-2.6.git/arch/x86/kernel/smpboot.c
===================================================================
--- linux-2.6.git.orig/arch/x86/kernel/smpboot.c 2008-09-18 19:17:16.000000000 +0400
+++ linux-2.6.git/arch/x86/kernel/smpboot.c 2008-09-22 13:30:36.000000000 +0400
@@ -893,8 +893,10 @@ do_rest:
/*
* Be paranoid about clearing APIC errors.
*/
- apic_write(APIC_ESR, 0);
- apic_read(APIC_ESR);
+ if (APIC_INTEGRATED(apic_version[phys_apicid])) {
+ apic_write(APIC_ESR, 0);
+ apic_read(APIC_ESR);
+ }
}
/*
next reply other threads:[~2008-09-22 9:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 9:36 Cyrill Gorcunov [this message]
2008-09-22 9:51 ` [PATCH] x86: do_boot_cpu - add check if we have ESR register Cyrill Gorcunov
2008-09-22 9:57 ` Yinghai Lu
2008-09-22 10:00 ` Ingo Molnar
2008-09-22 10:04 ` Cyrill Gorcunov
2008-09-22 10:15 ` Cyrill Gorcunov
2008-09-22 18:37 ` Yinghai Lu
2008-09-22 19:21 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080922093603.GC7663@localhost \
--to=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.