From: Robert Richter <robert.richter@amd.com>
To: Andrea Righi <righi.andrea@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
oprofile-list@lists.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH -mm] oprofile: BUG scheduling while atomic
Date: Mon, 22 Sep 2008 15:13:10 +0200 [thread overview]
Message-ID: <20080922131309.GL23557@erda.amd.com> (raw)
In-Reply-To: <48D51E93.90804@gmail.com>
Forgot to cc Ingo.
-Robert
On 20.09.08 18:02:27, Andrea Righi wrote:
> nmi_shutdown() calls unregister_die_notifier() from an atomic context
> after setting preempt_disable() via get_cpu_var():
>
> [ 1049.404154] BUG: scheduling while atomic: oprofiled/7796/0x00000002
> [ 1049.404171] INFO: lockdep is turned off.
> [ 1049.404176] Modules linked in: oprofile af_packet rfcomm l2cap kvm_intel kvm i915 drm acpi_cpufreq cpufreq_userspace cpufreq_conservative cpufreq_ondemand cpufreq_powersave freq_table container sbs sbshc dm_mod arc4 ecb cryptomgr aead snd_hda_intel crypto_blkcipher snd_pcm_oss crypto_algapi snd_pcm iwlagn iwlcore snd_timer iTCO_wdt led_class btusb iTCO_vendor_support snd psmouse bluetooth mac80211 soundcore cfg80211 snd_page_alloc intel_agp video output button battery ac dcdbas evdev ext3 jbd mbcache sg sd_mod piix ata_piix libata scsi_mod dock tg3 libphy ehci_hcd uhci_hcd usbcore thermal processor fan fuse
> [ 1049.404362] Pid: 7796, comm: oprofiled Not tainted 2.6.27-rc5-mm1 #30
> [ 1049.404368] Call Trace:
> [ 1049.404384] [<ffffffff804769fd>] thread_return+0x4a0/0x7d3
> [ 1049.404396] [<ffffffff8026ad92>] generic_exec_single+0x52/0xe0
> [ 1049.404405] [<ffffffff8026ae1a>] generic_exec_single+0xda/0xe0
> [ 1049.404414] [<ffffffff8026aee3>] smp_call_function_single+0x73/0x150
> [ 1049.404423] [<ffffffff804770c5>] schedule_timeout+0x95/0xd0
> [ 1049.404430] [<ffffffff80476083>] wait_for_common+0x43/0x180
> [ 1049.404438] [<ffffffff80476154>] wait_for_common+0x114/0x180
> [ 1049.404448] [<ffffffff80236980>] default_wake_function+0x0/0x10
> [ 1049.404457] [<ffffffff8024f810>] synchronize_rcu+0x30/0x40
> [ 1049.404463] [<ffffffff8024f890>] wakeme_after_rcu+0x0/0x10
> [ 1049.404472] [<ffffffff80479ca0>] _spin_unlock_irqrestore+0x40/0x80
> [ 1049.404482] [<ffffffff80256def>] atomic_notifier_chain_unregister+0x3f/0x60
> [ 1049.404501] [<ffffffffa03d8801>] nmi_shutdown+0x51/0x90 [oprofile]
> [ 1049.404517] [<ffffffffa03d6134>] oprofile_shutdown+0x34/0x70 [oprofile]
> [ 1049.404532] [<ffffffffa03d721e>] event_buffer_release+0xe/0x40 [oprofile]
> [ 1049.404543] [<ffffffff802bdcdd>] __fput+0xcd/0x240
> [ 1049.404551] [<ffffffff802baa74>] filp_close+0x54/0x90
> [ 1049.404560] [<ffffffff8023e1d1>] put_files_struct+0xb1/0xd0
> [ 1049.404568] [<ffffffff8023f82f>] do_exit+0x18f/0x930
> [ 1049.404576] [<ffffffff8020be03>] restore_args+0x0/0x30
> [ 1049.404584] [<ffffffff80240006>] do_group_exit+0x36/0xa0
> [ 1049.404592] [<ffffffff8020b7cb>] system_call_fastpath+0x16/0x1b
>
> This can be easily triggered with 'opcontrol --shutdown'.
>
> Simply move get_cpu_var() above unregister_die_notifier().
>
> Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
Acked-by: Robert Richter <robert@richter@amd.com>
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com
prev parent reply other threads:[~2008-09-22 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-20 16:02 [PATCH -mm] oprofile: BUG scheduling while atomic Andrea Righi
2008-09-22 9:55 ` Ingo Molnar
2008-09-22 13:10 ` Robert Richter
2008-09-22 13:13 ` Robert Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080922131309.GL23557@erda.amd.com \
--to=robert.richter@amd.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oprofile-list@lists.sourceforge.net \
--cc=righi.andrea@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.