From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] x86,amd,microcode: fix hypercall return code Date: Mon, 22 Sep 2008 14:59:10 +0200 Message-ID: <200809221459.10713.Christoph.Egger@amd.com> References: <200809221422.32502.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: "Tian, Kevin" List-Id: xen-devel@lists.xenproject.org On Monday 22 September 2008 14:47:38 Tian, Kevin wrote: > >From: Christoph Egger > >Sent: 2008=E5=B9=B49=E6=9C=8822=E6=97=A5 20:23 > > > > > >Hi, > > > >Attached patch makes the hypercall return failure > >if the microcode didn't apply. > > > >Signed-off-by: Christoph Egger > > It's weird that you don't add a 'break' if apply_microcode failed, > unless you're sure next invocation to get_next_ucode_from_buffer > _amd return 0... But even that, this is a bad coding style. Yes, it is. Note, I ported that code from Linux. I don't know if code from BSD would have been accepted due to license incompatibilities. Christoph =2D-=20 AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Gesch=C3=A4ftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplement=C3=A4r: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Gesch=C3=A4ftsf=C3=BChrer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy