Re: [PATCH] don't enter guest after SIPI was received by a CPU

[Marcelo Tosatti <mtosatti@redhat.com>]

Looks good. Thanks Gleb.

On Mon, Sep 22, 2008 at 02:28:53PM +0300, Gleb Natapov wrote:
> Don't enter guest after SIPI was issued.
> 
> CPU should process SIPI message before entering a guest mode again.
> kvm_arch_vcpu_runnable() return true if CPU is in SIPI state, so
> we can't call it here.
> 
> Signed-off-by: Gleb Natapov <gleb@qumranet.com>
> 
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 61eddbe..612099f 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -3239,7 +3239,7 @@ static int __vcpu_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run)
>  
>  	r = 1;
>  	while (r > 0) {
> -		if (kvm_arch_vcpu_runnable(vcpu))
> +		if (vcpu->arch.mp_state == KVM_MP_STATE_RUNNABLE)
>  			r = vcpu_enter_guest(vcpu, kvm_run);
>  		else {
>  			up_read(&vcpu->kvm->slots_lock);
> --
> 			Gleb.