All of lore.kernel.org
 help / color / mirror / Atom feed
From: akpm@linux-foundation.org
To: trond.myklebust@fys.uio.no
Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org,
	akpm@linux-foundation.org,
	richard-GNCsCaawp5mSE57U5PDhIQ@public.gmane.org
Subject: [patch 3/3] nfs: remove 8 bytes of padding from struct nfs_fattr on 64 bit builds
Date: Mon, 22 Sep 2008 14:54:35 -0700	[thread overview]
Message-ID: <200809222154.m8MLsZdR032103@imap1.linux-foundation.org> (raw)

From: Richard Kennedy <richard-GNCsCaawp5mSE57U5PDhIQ@public.gmane.org>

remove 8 bytes of padding from struct nfs_fattr on 64 bit builds

This also removes padding from several nfs structures, including
16 bytes from  nfs4_opendata, nfs4_createdata,nfs3_createdata
& 8 bytes from nfs_read_data,nfs_write_data,nfs_removeres,nfs4_closedata

This also reduces the reported stack usage of many nfs functions (30+).

Signed-off-by: Richard Kennedy <richard-GNCsCaawp5mSE57U5PDhIQ@public.gmane.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 include/linux/nfs_xdr.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN include/linux/nfs_xdr.h~nfs-remove-8-bytes-of-padding-from-struct-nfs_fattr-on-64-bit-builds include/linux/nfs_xdr.h
--- a/include/linux/nfs_xdr.h~nfs-remove-8-bytes-of-padding-from-struct-nfs_fattr-on-64-bit-builds
+++ a/include/linux/nfs_xdr.h
@@ -36,6 +36,7 @@ struct nfs_fattr {
 	__u32			nlink;
 	__u32			uid;
 	__u32			gid;
+	dev_t			rdev;
 	__u64			size;
 	union {
 		struct {
@@ -46,7 +47,6 @@ struct nfs_fattr {
 			__u64	used;
 		} nfs3;
 	} du;
-	dev_t			rdev;
 	struct nfs_fsid		fsid;
 	__u64			fileid;
 	struct timespec		atime;
_

                 reply	other threads:[~2008-09-22 21:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200809222154.m8MLsZdR032103@imap1.linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=richard-GNCsCaawp5mSE57U5PDhIQ@public.gmane.org \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.