All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Fasheh <mfasheh@suse.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 2/3] ocfs2: Add security xattr support in ocfs2
Date: Mon, 22 Sep 2008 23:28:53 -0700	[thread overview]
Message-ID: <20080923062853.GT4563@wotan.suse.de> (raw)
In-Reply-To: <1221817353-11111-1-git-send-email-tiger.yang@oracle.com>

On Fri, Sep 19, 2008 at 05:42:33PM +0800, Tiger Yang wrote:
> This patch add security extended attribute support in ocfs2.

Ok, thanks for this.


> +struct xattr_handler ocfs2_xattr_security_handler = {
> +	.prefix	= XATTR_SECURITY_PREFIX,
> +	.list	= ocfs2_xattr_security_list,
> +	.get	= ocfs2_xattr_security_get,
> +	.set	= ocfs2_xattr_security_set,
> +};

Don't we need to add a call to 'security_inode_init_security()' when creating a new
inode?

The patch otherwise looks good. How was it tested?
	--Mark

--
Mark Fasheh

  reply	other threads:[~2008-09-23  6:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-19  9:35 [Ocfs2-devel] [PATCH 0/3] ocfs2: add security EA and ACL support v1 Tiger Yang
2008-09-19  9:42 ` [Ocfs2-devel] [PATCH 1/3] ocfs2: small fix in xattr Tiger Yang
2008-09-19  9:42 ` [Ocfs2-devel] [PATCH 2/3] ocfs2: Add security xattr support in ocfs2 Tiger Yang
2008-09-23  6:28   ` Mark Fasheh [this message]
2008-09-24  7:37     ` Tiger Yang
2008-09-24  8:47       ` Mark Fasheh
2008-09-23  6:33   ` Mark Fasheh
2008-09-24  7:44     ` Tiger Yang
2008-09-24  8:51       ` Mark Fasheh
2008-10-02  8:09     ` Christoph Hellwig
2008-09-19  9:43 ` [Ocfs2-devel] [PATCH 3/3] ocfs2: Add posix ACL support in ocfs2 v1 Tiger Yang
2008-09-23  7:11   ` Mark Fasheh
2008-09-24  8:01     ` Tiger Yang
2008-09-24  9:02       ` Mark Fasheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080923062853.GT4563@wotan.suse.de \
    --to=mfasheh@suse.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.