All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Russ Anderson <rja@sgi.com>, Huang@elte.hu, Ying <ying.huang@intel.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
	"H. Peter Anvin" <hpa@zytor.com>, Jack Steiner <steiner@sgi.com>
Subject: Re: [PATCH 2/4] x86: Add UV bios call infrastructure
Date: Tue, 23 Sep 2008 13:07:11 +0200	[thread overview]
Message-ID: <20080923110711.GD29021@elte.hu> (raw)
In-Reply-To: <20080922210928.GE222374@sgi.com>


* Russ Anderson <rja@sgi.com> wrote:

> +/*
> + * IF EFI is not configured, have the EFI calls return unimplemented.
> + */
> +u64 efi_call6(void *fp, u64 arg1, u64 arg2, u64 arg3,
> +			u64 arg4, u64 arg5, u64 arg6)
> +{
> +	return  BIOS_STATUS_UNIMPLEMENTED;
> +}

> +#ifndef CONFIG_EFI
> +extern u64 efi_call6(void *, u64, u64, u64, u64, u64, u64);
> +#endif

shouldnt this be done in include/asm-x86/efi.h and 
arch/x86/kernel/efi_stub_64.S instead?

	Ingo

  parent reply	other threads:[~2008-09-23 11:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-22 21:09 [PATCH 2/4] x86: Add UV bios call infrastructure Russ Anderson
2008-09-22 22:07 ` H. Peter Anvin
2008-09-22 22:18   ` Russ Anderson
2008-09-23 11:07 ` Ingo Molnar [this message]
2008-09-24  3:20 ` Huang Ying
  -- strict thread matches above, loose matches on Subject: below --
2008-08-22 21:53 Russ Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080923110711.GD29021@elte.hu \
    --to=mingo@elte.hu \
    --cc=Huang@elte.hu \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rja@sgi.com \
    --cc=steiner@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.