From: Alex Chiang <achiang@hp.com>
To: unlisted-recipients:; (no To-header on input)
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
jbarnes@virtuousgeek.org, kristen.c.accardi@intel.com,
matthew@wil.cx, kaneshige.kenji@jp.fujitsu.com,
Alex Chiang <achiang@hp.com>
Subject: [PATCH v3 13/14] PCI: Hotplug core: remove 'name'
Date: Tue, 23 Sep 2008 10:46:19 -0600 [thread overview]
Message-ID: <20080923164619.12628.44585.stgit@bob.kio> (raw)
In-Reply-To: <20080923163753.12628.98683.stgit@bob.kio>
Now that the PCI core manages the 'name' for each individual
hotplug driver, and all drivers have been converted to use
hotplug_slot_name(), there is no need for the PCI hotplug
core to drag around its own copy of name either.
Cc: jbarnes@virtuousgeek.org
Cc: kristen.c.accardi@intel.com
Cc: matthew@wil.cx
Cc: kaneshige.kenji@jp.fujitsu.com
Signed-off-by: Alex Chiang <achiang@hp.com>
---
drivers/pci/hotplug/pci_hotplug_core.c | 6 +++---
include/linux/pci_hotplug.h | 3 ---
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
index 46802dc..2a29ad0 100644
--- a/drivers/pci/hotplug/pci_hotplug_core.c
+++ b/drivers/pci/hotplug/pci_hotplug_core.c
@@ -533,7 +533,7 @@ static struct hotplug_slot *get_slot_from_name (const char *name)
spin_lock(&pci_hotplug_slot_list_lock);
list_for_each (tmp, &pci_hotplug_slot_list) {
slot = list_entry (tmp, struct hotplug_slot, slot_list);
- if (strcmp(slot->name, name) == 0)
+ if (strcmp(hotplug_slot_name(slot), name) == 0)
goto out;
}
slot = NULL;
@@ -628,7 +628,7 @@ int pci_hp_deregister(struct hotplug_slot *hotplug)
if (!hotplug)
return -ENODEV;
- temp = get_slot_from_name(hotplug->name);
+ temp = get_slot_from_name(hotplug_slot_name(hotplug));
if (temp != hotplug)
return -ENODEV;
@@ -638,7 +638,7 @@ int pci_hp_deregister(struct hotplug_slot *hotplug)
slot = hotplug->pci_slot;
fs_remove_slot(slot);
- dbg("Removed slot %s from the list\n", hotplug->name);
+ dbg("Removed slot %s from the list\n", hotplug_slot_name(hotplug));
hotplug->release(hotplug);
slot->hotplug = NULL;
diff --git a/include/linux/pci_hotplug.h b/include/linux/pci_hotplug.h
index 7184bee..9899ea3 100644
--- a/include/linux/pci_hotplug.h
+++ b/include/linux/pci_hotplug.h
@@ -142,8 +142,6 @@ struct hotplug_slot_info {
/**
* struct hotplug_slot - used to register a physical slot with the hotplug pci core
- * @name: the name of the slot being registered. This string must
- * be unique amoung slots registered on this system.
* @ops: pointer to the &struct hotplug_slot_ops to be used for this slot
* @info: pointer to the &struct hotplug_slot_info for the initial values for
* this slot.
@@ -153,7 +151,6 @@ struct hotplug_slot_info {
* needs.
*/
struct hotplug_slot {
- char *name;
struct hotplug_slot_ops *ops;
struct hotplug_slot_info *info;
void (*release) (struct hotplug_slot *slot);
next prev parent reply other threads:[~2008-09-23 16:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-23 16:45 [PATCH v3 00/14] PCI: let the core manage slot names Alex Chiang
2008-09-23 16:45 ` [PATCH v3 01/14] PCI Hotplug core: add 'name' param pci_hp_register interface Alex Chiang
2008-09-23 16:45 ` [PATCH v3 02/14] PCI: prevent duplicate slot names Alex Chiang
[not found] ` <48E09936.2030905@jp.fujitsu.com>
2008-09-30 2:06 ` Kenji Kaneshige
2008-10-02 1:05 ` Alex Chiang
2008-10-02 2:47 ` Kenji Kaneshige
2008-10-02 4:48 ` Alex Chiang
2008-10-03 1:33 ` Kenji Kaneshige
2008-09-23 16:45 ` [PATCH v3 03/14] PCI, PCI Hotplug: introduce slot_name helpers Alex Chiang
2008-09-23 16:45 ` [PATCH v3 04/14] PCI: acpiphp: remove 'name' parameter Alex Chiang
2008-09-23 16:45 ` [PATCH v3 05/14] PCI: cpci_hotplug: stop managing hotplug_slot->name Alex Chiang
2008-09-23 16:45 ` [PATCH v3 06/14] PCI: cpqphp: " Alex Chiang
2008-09-23 16:45 ` [PATCH v3 07/14] PCI: fakephp: remove 'name' parameter Alex Chiang
2008-09-23 16:45 ` [PATCH v3 08/14] PCI: ibmphp: stop managing hotplug_slot->name Alex Chiang
2008-09-23 16:45 ` [PATCH v3 09/14] PCI: pciehp: remove 'name' parameter Alex Chiang
2008-09-23 16:46 ` [PATCH v3 10/14] PCI: rpaphp: stop managing hotplug_slot->name Alex Chiang
2008-09-23 16:46 ` [PATCH v3 11/14] PCI: SGI Hotplug: stop managing bss_hotplug_slot->name Alex Chiang
2008-09-23 16:46 ` [PATCH v3 12/14] PCI: shcphp: remove 'name' parameter Alex Chiang
2008-09-23 16:46 ` Alex Chiang [this message]
2008-09-23 16:46 ` [PATCH v3 14/14] PCI Hotplug: fakephp: add duplicate slot name debugging Alex Chiang
2008-09-24 8:47 ` [PATCH v3 00/14] PCI: let the core manage slot names Kenji Kaneshige
2008-09-26 8:06 ` Taku Izumi
2008-10-01 21:04 ` Alex Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080923164619.12628.44585.stgit@bob.kio \
--to=achiang@hp.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=kristen.c.accardi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.