From: Dave Chinner <david@fromorbit.com>
To: Peter Leckie <pleckie@sgi.com>
Cc: xfs@oss.sgi.com, xfs-dev <xfs-dev@sgi.com>
Subject: Re: [PATCH] don't use signed int to store xfs_dqid_t
Date: Wed, 24 Sep 2008 16:07:39 +1000 [thread overview]
Message-ID: <20080924060739.GI5448@disturbed> (raw)
In-Reply-To: <48D9C653.1030908@sgi.com>
On Wed, Sep 24, 2008 at 02:47:15PM +1000, Peter Leckie wrote:
> When running xfsqa test 144 with quota's enabled it's possible to
> trip the following ASSERT(curid >= 0); from xfs_qm_init_dquot_blk().
> The reason this assert was tripped is the signed int currid was assigned
> an id from the unsigned xfs_dqid_t this works as long as the MSB in
> xfs_dqid_t
> is not set. However if it is this translates to a negative number causing
> the assert to trip.
>
> The fix for this is simply replacing the signed int with type xfs_dqid_t
> and since xfs_dqid_t is unsigned there is no point checking if it's negative
> so remove the assert.
Looks good.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2008-09-24 6:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 4:47 [PATCH] don't use signed int to store xfs_dqid_t Peter Leckie
2008-09-24 6:07 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080924060739.GI5448@disturbed \
--to=david@fromorbit.com \
--cc=pleckie@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.