All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@booyaka.com>
Cc: Arun KS <arunks@mistralsolutions.com>,
	Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH] Temporary fix to boot OMAP1 based boards
Date: Wed, 24 Sep 2008 11:06:53 +0300	[thread overview]
Message-ID: <20080924080652.GG5222@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0809240202250.15312@utopia.booyaka.com>

* Paul Walmsley <paul@booyaka.com> [080924 11:03]:
> On Wed, 24 Sep 2008, Tony Lindgren wrote:
> 
> > * Tony Lindgren <tony@atomide.com> [080924 10:12]:
> > > * Arun KS <arunks@mistralsolutions.com> [080924 10:05]:
> > > > On Wed, Sep 24, 2008 at 9:21 AM, Hiroshi DOYU <Hiroshi.DOYU@nokia.com> wrote:
> > > > > Hi,
> > > > >
> > > > > How about introducing a new typedef in order to accommodate the
> > > > > different size of enable_regs without ifdefs?
> > > > >
> > > > > I think that this is apparently the case categorized into (a) in
> > > > > 'CodyingStyle'.
> > > > 
> > > > I am not sure which is the right way to do. Is this what you meant?
> > > 
> > > No, let's not do this. It should be void __iomem * for sure. Most of
> > > the omap1 clock registers looks just fine for void __iomem *, let's
> > > figure out which registers are broken.
> > 
> > I've pushed a fix for this. Turns out I missed some conversions to
> > void __iomem * while merging code from arm-devel branch. Fix also
> > attached.
> 
> Those registers should be u16 for OMAP2/3.  OMAP1 needs something similar, 
> which will also get rid of those casts to void __iomem * - hacking on 
> something now ...

Argh, sorry. Yeah it's an offset for omap2/3.. Will revert immediately.

Tony

  reply	other threads:[~2008-09-24  8:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-23 15:23 [PATCH] Temporary fix to boot OMAP1 based boards Arun KS
2008-09-23 22:43 ` Felipe Balbi
2008-09-24  4:50   ` Arun KS
2008-09-24  3:51 ` Hiroshi DOYU
2008-09-24  7:05   ` Arun KS
2008-09-24  7:12     ` Tony Lindgren
2008-09-24  8:00       ` Tony Lindgren
2008-09-24  8:03         ` Paul Walmsley
2008-09-24  8:06           ` Tony Lindgren [this message]
2008-09-24  8:08             ` Paul Walmsley
2008-09-24  8:34               ` Tony Lindgren
2008-09-24  9:03                 ` Arun KS
2008-09-24 14:06                 ` Paul Walmsley
2008-09-24 14:27                   ` Tony Lindgren
2008-09-24 14:35                     ` Paul Walmsley
2008-09-24 14:43                       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080924080652.GG5222@atomide.com \
    --to=tony@atomide.com \
    --cc=Hiroshi.DOYU@nokia.com \
    --cc=arunks@mistralsolutions.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@booyaka.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.