From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amit Shah Subject: Re: [PATCH 4/7] qemu: Include hw.h in qemu/hw/isa.h to fix compile issues Date: Wed, 24 Sep 2008 09:57:39 +0530 Message-ID: <200809240957.39770.amit.shah@redhat.com> References: <1222181695-23418-1-git-send-email-amit.shah@redhat.com> <1222181695-23418-5-git-send-email-amit.shah@redhat.com> <48D915B8.6040401@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: avi@redhat.com, kvm@vger.kernel.org, muli@il.ibm.com, benami@il.ibm.com, weidong.han@intel.com, allen.m.kay@intel.com To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([66.187.233.31]:43520 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750741AbYIXE3p convert rfc822-to-8bit (ORCPT ); Wed, 24 Sep 2008 00:29:45 -0400 In-Reply-To: <48D915B8.6040401@codemonkey.ws> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: * On Tuesday 23 Sep 2008 21:43:44 Anthony Liguori wrote: > Amit Shah wrote: > > Signed-off-by: Amit Shah > > --- > > qemu/hw/isa.h | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/qemu/hw/isa.h b/qemu/hw/isa.h > > index 222e4f3..e4a1326 100644 > > --- a/qemu/hw/isa.h > > +++ b/qemu/hw/isa.h > > @@ -2,6 +2,8 @@ > > #define HW_ISA_H > > /* ISA bus */ > > > > +#include "hw.h" > > + > > extern target_phys_addr_t isa_mem_base; > > > > int register_ioport_read(int start, int length, int size, > > What compile issues? register_ioport_read* and register_ioport_write* functions cause a lot = of=20 this. gcc -I. -I.. -I/home/amit/src/kvm-userspace/qemu/target-i386 -I/home/am= it/src/kvm-userspace/qemu -MMD -MT=20 device-assignment.o -MP -DNEED_CPU_H -D_GNU_SOURCE -D_FILE_OFFSET_BITS=3D= 64 -D_LARGEFILE_SOURCE -D__user=3D -I/home/amit/src/kvm-userspace/qemu/= tcg -I/home/amit/src/kvm-userspace/qemu/tcg/x86_64 -I/home/amit/src/kvm= -userspace/qemu/fpu -DHAS_AUDIO -DHAS_AUDIO_CHOICE -I/home/amit/src/kv= m-userspace/qemu/slirp -I /home/amit/src/kvm-userspace/qemu/../libkvm = -DCONFIG_X86 -O2 -g -fno-strict-aliasing -Wall -Wundef -Wendif-labels -= Wwrite-strings -m64 -I /home/amit/src/kvm-userspace/kernel/include -c = -o=20 device-assignment.o /home/amit/src/kvm-userspace/qemu/hw/device-assignm= ent.c In file included from /home/amit/src/kvm-userspace/qemu/hw/pci.h:6, =20 from /home/amit/src/kvm-userspace/qemu/hw/device-assignment.h:34, =20 from /home/amit/src/kvm-userspace/qemu/hw/device-assignment.c:32: /home/amit/src/kvm-userspace/qemu/hw/isa.h:8: error: expected declarati= on=20 specifiers or =E2...=E2 before =E2IOPortReadFunc=E2 /home/amit/src/kvm-userspace/qemu/hw/isa.h:10: error: expected declarat= ion=20 specifiers or =E2...=E2 before =E2IOPortWriteFunc=E2 /home/amit/src/kvm-userspace/qemu/hw/device-assignment.c: In function=20 =E2assigned_dev_ioport_map=E2: /home/amit/src/kvm-userspace/qemu/hw/device-assignment.c:193: error: to= o many=20 arguments to function =E2register_ioport_read=E2 /home/amit/src/kvm-userspace/qemu/hw/device-assignment.c:195: error: to= o many=20 arguments to function =E2register_ioport_read=E2 /home/amit/src/kvm-userspace/qemu/hw/device-assignment.c:197: error: to= o many=20 arguments to function =E2register_ioport_read=E2 /home/amit/src/kvm-userspace/qemu/hw/device-assignment.c:199: error: to= o many=20 arguments to function =E2register_ioport_write=E2 /home/amit/src/kvm-userspace/qemu/hw/device-assignment.c:201: error: to= o many=20 arguments to function =E2register_ioport_write=E2 /home/amit/src/kvm-userspace/qemu/hw/device-assignment.c:203: error: to= o many=20 arguments to function =E2register_ioport_write=E2 make[2]: *** [device-assignment.o] Error 1 make[2]: Leaving directory `/home/amit/src/kvm-userspace/qemu/x86_64-so= ftmmu' make[1]: *** [subdir-x86_64-softmmu] Error 2 make[1]: Leaving directory `/home/amit/src/kvm-userspace/qemu' make: *** [qemu] Error 2