From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KiRjT-000886-T9 for mharc-grub-devel@gnu.org; Wed, 24 Sep 2008 06:36:31 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KiRjR-00086T-88 for grub-devel@gnu.org; Wed, 24 Sep 2008 06:36:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KiRjO-00084j-Jp for grub-devel@gnu.org; Wed, 24 Sep 2008 06:36:28 -0400 Received: from [199.232.76.173] (port=48398 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KiRjO-00084U-68 for grub-devel@gnu.org; Wed, 24 Sep 2008 06:36:26 -0400 Received: from aybabtu.com ([69.60.117.155]:51033) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KiRjN-0001K6-JB for grub-devel@gnu.org; Wed, 24 Sep 2008 06:36:25 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KiRWx-0003Bd-R6 for grub-devel@gnu.org; Wed, 24 Sep 2008 12:23:37 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KiRhQ-0004Vs-O1 for grub-devel@gnu.org; Wed, 24 Sep 2008 12:34:24 +0200 Date: Wed, 24 Sep 2008 12:34:24 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080924103424.GK6973@thorin> References: <20080920203745.GA27562@pina.cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080920203745.GA27562@pina.cat> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Menu control for NPAGE and PPAGE X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2008 10:36:30 -0000 On Sat, Sep 20, 2008 at 10:37:45PM +0200, Carles Pina i Estany wrote: > > Hello, > > (This patch includes the changes for GRUB_TERM_NPAGE/PPAGE macros, that > I sent in a previous mail) > > ChangeLog: > -------- > 2008-09-20 Carles Pina i Estany > * normal/menu.c (run_menu): Add Previous and Next Page keys in > grub-menu. > > * include/grub/powerpc/ieee1275/console.h (GRUB_TERM_NPAGE): > Changed to 0x5100. > (GRUB_TERM_PPAGE): Changed to 0x4900. > > * include/grub/sparc64/ieee1275/console.h: Likewise. > > * include/grub/i386/pc/console.h: Likewise. > > * include/grub/efi/console.h: Likewise. > -------- The scancode part is merged already, please update/resync. > + else > + { > + first = first - GRUB_TERM_NUM_ENTRIES; > + > + if (first < 0) > + { > + offset = offset + first; I'd suggest using '+=' and '-=' on these to make it more readable and avoid redundancy. > + case GRUB_TERM_NPAGE: > + if (offset==0) > + { > + offset = offset + GRUB_TERM_NUM_ENTRIES -1 ; > + if (first+offset>menu->size) > + { > + offset=menu->size-first-1; > + } > + } Please add spaces around '==', '>', '+', '-', etc. > + if (offset > menu->size - 1 || offset > GRUB_TERM_NUM_ENTRIES - 1) Does this generate a compiler warning? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."