All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: fangxiaozhi 00110321 <huananhu@huawei.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	zihan@huawei.com, Lin.Lei@huawei.com, zhangqianchun@huawei.com
Subject: Re: PATCH 10/4]linux-usb: To support more Huawei data card product IDs, fix kernel 2.6.27-rc7
Date: Wed, 24 Sep 2008 08:03:04 -0700	[thread overview]
Message-ID: <20080924150304.GC26466@kroah.com> (raw)
In-Reply-To: <f9fd97f63cf97.3cf97f9fd97f6@huawei.com>

On Wed, Sep 24, 2008 at 02:08:12PM +0800, fangxiaozhi 00110321 wrote:
> 
>  From: fangxiaozhi <huananhu@huawei.com>
>  
>  1. This patch is based on the kernel of 2.6.27-rc7 2. To declare the unusual device for new Huawei data card devices 
>  in unusual_devs.h
>  3. To modify the data value and length in the function of 
>  usb_stor_huawei_e220_init in initializers.c
>  4. To declare more new product IDs in option.c.

I thought I asked you to split this up into 4 different patches?  Hm,
maybe three should be all that is needed, I thought your original one
did 4 different things.

And isn't your modification of the usb_stor_huawei_e220_init function
going to break the devices that it currently works for?  Or has it
always been wrong?

thanks,

greg k-h

  parent reply	other threads:[~2008-09-24 15:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-24  2:07 [PATCH 10/4]linux-usb: To support more Huawei data card product IDs, fix kernel 2.6.26.5 fangxiaozhi 00110321
2008-09-24  2:30 ` Greg KH
2008-09-24  3:02   ` Franko Fang
2008-09-24  3:31     ` Greg KH
2008-09-24  6:08 ` PATCH 10/4]linux-usb: To support more Huawei data card product IDs, fix kernel 2.6.27-rc7 fangxiaozhi 00110321
2008-09-24 14:38   ` Alan Stern
2008-09-24 15:03   ` Greg KH [this message]
2008-09-25  1:36     ` PATCH 10/4]linux-usb: To support more Huawei data card productIDs, " Franko Fang
2008-09-25  2:10       ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2008-10-08  1:31 PATCH 10/4]linux-usb: To support more Huawei data card product IDs, " fangxiaozhi 00110321
2008-10-08  3:21 ` Greg KH
2008-10-08 14:07 ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080924150304.GC26466@kroah.com \
    --to=greg@kroah.com \
    --cc=Lin.Lei@huawei.com \
    --cc=huananhu@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=zhangqianchun@huawei.com \
    --cc=zihan@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.