From: Ingo Molnar <mingo@elte.hu>
To: "Frédéric Weisbecker" <fweisbec@gmail.com>
Cc: linux-kernel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [Patch -tip] x86/ftrace: use uaccess in atomic context
Date: Wed, 24 Sep 2008 17:11:18 +0200 [thread overview]
Message-ID: <20080924151118.GA26317@elte.hu> (raw)
In-Reply-To: <48DA5D6C.4010008@gmail.com>
* Frédéric Weisbecker <fweisbec@gmail.com> wrote:
> Hello,
>
> With last -tip I get this bug:
>
> [ 49.439988] in_atomic():0, irqs_disabled():1
> [ 49.440118] INFO: lockdep is turned off.
> [ 49.440118] Pid: 2814, comm: modprobe Tainted: G W 2.6.27-rc7 #4
> [ 49.440118] [<c01215e1>] __might_sleep+0xe1/0x120
> [ 49.440118] [<c01148ea>] ftrace_modify_code+0x2a/0xd0
> [ 49.440118] [<c01148a2>] ? ftrace_test_p6nop+0x0/0xa
> [ 49.440118] [<c016e80e>] __ftrace_update_code+0xfe/0x2f0
> [ 49.440118] [<c01148a2>] ? ftrace_test_p6nop+0x0/0xa
> [ 49.440118] [<c016f190>] ftrace_convert_nops+0x50/0x80
> [ 49.440118] [<c016f1d6>] ftrace_init_module+0x16/0x20
> [ 49.440118] [<c015498b>] load_module+0x185b/0x1d30
> [ 49.440118] [<c01767a0>] ? find_get_page+0x0/0xf0
> [ 49.440118] [<c02463c0>] ? sprintf+0x0/0x30
> [ 49.440118] [<c034e012>] ? mutex_lock_interruptible_nested+0x1f2/0x350
> [ 49.440118] [<c0154eb3>] sys_init_module+0x53/0x1b0
> [ 49.440118] [<c0352340>] ? do_page_fault+0x0/0x740
> [ 49.440118] [<c0104012>] syscall_call+0x7/0xb
> [ 49.440118] =======================
>
> It is because ftrace_modify_code() calls copy_to_user and
> copy_from_user.
> These functions have been inserted after guessing that there
> couldn't be any race condition but copy_[to/from]_user might
> sleep and __ftrace_update_code is called with local_irq_saved.
>
> These function have been inserted since this commit:
> d5e92e8978fd2574e415dc2792c5eb592978243d:
> "ftrace: x86 use copy from user function"
>
> Following is a patch which correct it.
applied to tip/tracing/ftrace, thanks Frédéric!
Ingo
prev parent reply other threads:[~2008-09-24 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 15:31 [Patch -tip] x86/ftrace: use uaccess in atomic context Frédéric Weisbecker
2008-09-24 14:31 ` Steven Rostedt
2008-09-24 15:11 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080924151118.GA26317@elte.hu \
--to=mingo@elte.hu \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.