From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [Bug #11382] e1000e: 2.6.27-rc1 corrupts EEPROM/NVM Date: Thu, 25 Sep 2008 13:06:19 -0700 (PDT) Message-ID: <20080925.130619.193699562.davem@davemloft.net> References: <200809250401.54818.elendil@planet.nl> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: Text/Plain; charset="us-ascii" To: jkosina-AlSwsSmVLrQ@public.gmane.org Cc: elendil-EIBgga6/0yRmR6Xm/wNWPw@public.gmane.org, airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jeff-o2qLIJkoznsdnm+yROfE0A@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, jeffrey.t.kirsher-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, david.vrabel-kQvG35nSl+M@public.gmane.org, rjw-KKrjLPT3xs0@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, chrisl-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org, mingo-X9Un+BFzKDI@public.gmane.org, jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org, jesse.brandeburg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org From: Jiri Kosina Date: Thu, 25 Sep 2008 19:24:57 +0200 (CEST) > If being set to 0 (it's so easy to call memset(0) on a bogus pointer, > there are usually lots of them in the code) or to random garbage, it would > seem to be much more understandable, than 0xff. Setting framebuffer bytes to 0xff is pretty common, for example for color keys and anti-aliasing pixel values. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755532AbYIYUGl (ORCPT ); Thu, 25 Sep 2008 16:06:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753457AbYIYUGc (ORCPT ); Thu, 25 Sep 2008 16:06:32 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:50336 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752293AbYIYUGc (ORCPT ); Thu, 25 Sep 2008 16:06:32 -0400 Date: Thu, 25 Sep 2008 13:06:19 -0700 (PDT) Message-Id: <20080925.130619.193699562.davem@davemloft.net> To: jkosina@suse.cz Cc: elendil@planet.nl, airlied@gmail.com, jeff@garzik.org, akpm@linux-foundation.org, jeffrey.t.kirsher@intel.com, david.vrabel@csr.com, rjw@sisk.pl, linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org, chrisl@vmware.com, mingo@elte.hu, jbarnes@virtuousgeek.org, jesse.brandeburg@gmail.com Subject: Re: [Bug #11382] e1000e: 2.6.27-rc1 corrupts EEPROM/NVM From: David Miller In-Reply-To: References: <200809250401.54818.elendil@planet.nl> X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiri Kosina Date: Thu, 25 Sep 2008 19:24:57 +0200 (CEST) > If being set to 0 (it's so easy to call memset(0) on a bogus pointer, > there are usually lots of them in the code) or to random garbage, it would > seem to be much more understandable, than 0xff. Setting framebuffer bytes to 0xff is pretty common, for example for color keys and anti-aliasing pixel values.