From: Michael Buesch <mb@bu3sch.de>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>,
Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org
Subject: Re: [PATCH 1/6] [MIPS] BCM47xx: Add platform specific PCI code
Date: Thu, 25 Sep 2008 00:31:00 +0200 [thread overview]
Message-ID: <200809250031.00844.mb@bu3sch.de> (raw)
In-Reply-To: <48DABBBE.7060201@ru.mvista.com>
On Thursday 25 September 2008 00:14:22 Sergei Shtylyov wrote:
> > + WARN_ON((res == 0) || (res == 1));
>
> Unneeded ()...
> > + err = ssb_pcibios_plat_dev_init(dev);
> > + if (err) {
> > + printk(KERN_ALERT "PCI: Failed to init device %s\n",
> > + pci_name(dev));
> > + }
> >
>
> Unneeded {}...
You must me kidding.
Get this freaking regression fix upstream, please.
We're not going to respin it to fix trivial taste issues.
(The above code is _perfectly_ fine and doesn't violate any rule).
--
Greetings Michael.
next prev parent reply other threads:[~2008-09-24 23:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 19:18 [PATCH 0/6] BCM47xx patches Aurelien Jarno
2008-09-24 19:19 ` [PATCH 1/6] [MIPS] BCM47xx: Add platform specific PCI code Aurelien Jarno
2008-09-24 21:17 ` Michael Buesch
2008-09-24 22:14 ` Sergei Shtylyov
2008-09-24 22:31 ` Michael Buesch [this message]
2008-09-25 0:14 ` John W. Linville
2008-09-25 9:54 ` Sergei Shtylyov
2008-09-25 0:18 ` John W. Linville
2008-09-25 0:18 ` John W. Linville
2008-09-25 10:05 ` Sergei Shtylyov
2008-09-25 12:32 ` Aurelien Jarno
2008-09-25 14:39 ` Sergei Shtylyov
2008-09-25 20:59 ` Michael Buesch
2008-09-25 17:24 ` John W. Linville
2008-09-25 21:00 ` Michael Buesch
2008-09-26 15:42 ` Ralf Baechle
2008-09-26 18:23 ` [PATCH 1/6 v2] " Aurelien Jarno
2008-09-27 14:06 ` [PATCH 1/6 v3] " Aurelien Jarno
2008-09-27 14:35 ` Ralf Baechle
2008-09-24 19:20 ` [PATCH 2/6] [MIPS] WGT634U: Add machine detection message Aurelien Jarno
2008-09-24 19:21 ` [PATCH 3/6] [MIPS] Remove references to BCM947XX Aurelien Jarno
2008-09-24 19:22 ` [PATCH 4/6] [MIPS] BCM47xx: Use the new SSB GPIO API Aurelien Jarno
2008-09-24 19:23 ` [PATCH 5/6] [MIPS] Add WGT634U reset button support Aurelien Jarno
2008-09-24 19:23 ` [PATCH 6/6] [MIPS] Scan PCI busses when they are registered Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809250031.00844.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=aurelien@aurel32.net \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.