From: Ingo Molnar <mingo@elte.hu>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com,
linux-kernel@vger.kernel.org, fujita.tomonori@lab.ntt.co.jp
Subject: Re: [PATCH 3/3] x86/iommu: use __GFP_ZERO instead of memset for GART
Date: Thu, 25 Sep 2008 12:20:12 +0200 [thread overview]
Message-ID: <20080925102012.GA13631@elte.hu> (raw)
In-Reply-To: <1222337635-28285-4-git-send-email-joerg.roedel@amd.com>
* Joerg Roedel <joerg.roedel@amd.com> wrote:
> #ifdef CONFIG_IOMMU_LEAK
> if (leak_trace) {
> - iommu_leak_tab = (void *)__get_free_pages(GFP_KERNEL,
> + iommu_leak_tab = (void *)__get_free_pages(GFP_KERNEL|__GFP_ZERO,
> get_order(iommu_pages*sizeof(void *)));
> - if (iommu_leak_tab)
> - memset(iommu_leak_tab, 0, iommu_pages * 8);
> else
> printk(KERN_DEBUG
> "PCI-DMA: Cannot allocate leak trace area\n");
hm, that looks broken.
Ingo
next prev parent reply other threads:[~2008-09-25 10:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 10:13 [PATCH 0/3] some small GART cleanups Joerg Roedel
2008-09-25 10:13 ` [PATCH 1/3] x86/iommu: make GART driver checkpatch clean Joerg Roedel
2008-09-25 10:13 ` [PATCH 2/3] x86/iommu: convert GART need_flush to bool Joerg Roedel
2008-09-25 10:13 ` [PATCH 3/3] x86/iommu: use __GFP_ZERO instead of memset for GART Joerg Roedel
2008-09-25 10:20 ` Ingo Molnar [this message]
2008-09-25 10:42 ` Joerg Roedel
2008-09-27 18:14 ` Ingo Molnar
2008-09-27 18:18 ` Ingo Molnar
2008-09-28 18:06 ` FUJITA Tomonori
2008-09-28 19:34 ` Joerg Roedel
2008-09-29 8:56 ` Ingo Molnar
2008-09-29 14:11 ` FUJITA Tomonori
2008-09-30 11:03 ` Ingo Molnar
2008-09-30 20:53 ` H. Peter Anvin
2008-09-28 14:48 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080925102012.GA13631@elte.hu \
--to=mingo@elte.hu \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hpa@zytor.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.