All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-omap@vger.kernel.org
Subject: Re: [patch 2.6.27-rc6-omap] hsmmc: request_irq says which controller is involved
Date: Thu, 25 Sep 2008 15:50:30 +0300	[thread overview]
Message-ID: <20080925125029.GS5222@atomide.com> (raw)
In-Reply-To: <200809211416.14496.david-b@pacbell.net>

* David Brownell <david-b@pacbell.net> [080922 00:50]:
> Make the hsmmc driver irq requests say which controller they're
> associated with (e.g. "mmc0") so /proc/interrupts is more useful.

Pushing today.

Tony

> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> 
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -908,8 +908,8 @@ static int __init omap_mmc_probe(struct platform_device *pdev)
>  			OMAP_HSMMC_READ(host->base, HCTL) | SDBP);
>  
>  	/* Request IRQ for MMC operations */
> -	ret = request_irq(host->irq, mmc_omap_irq, IRQF_DISABLED, pdev->name,
> -			 host);
> +	ret = request_irq(host->irq, mmc_omap_irq, IRQF_DISABLED,
> +			mmc_hostname(mmc), host);
>  	if (ret) {
>  		dev_dbg(mmc_dev(host->mmc), "Unable to grab HSMMC IRQ\n");
>  		goto err_irq;
> @@ -918,8 +918,8 @@ static int __init omap_mmc_probe(struct platform_device *pdev)
>  	/* Request IRQ for card detect */
>  	if ((mmc_slot(host).card_detect_irq) && (mmc_slot(host).card_detect)) {
>  		ret = request_irq(mmc_slot(host).card_detect_irq,
> -				  omap_mmc_cd_handler, IRQF_DISABLED, "MMC CD",
> -				  host);
> +				  omap_mmc_cd_handler, IRQF_DISABLED,
> +				  mmc_hostname(mmc), host);
>  		if (ret) {
>  			dev_dbg(mmc_dev(host->mmc),
>  				"Unable to grab MMC CD IRQ\n");
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2008-09-25 12:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-21 21:16 [patch 2.6.27-rc6-omap] hsmmc: request_irq says which controller is involved David Brownell
2008-09-25 12:50 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080925125029.GS5222@atomide.com \
    --to=tony@atomide.com \
    --cc=david-b@pacbell.net \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.