From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Inefficient code in NetLoop() ?
Date: Fri, 26 Sep 2008 09:55:59 +0200 [thread overview]
Message-ID: <200809260955.59674.sr@denx.de> (raw)
In-Reply-To: <20080926073653.15DEE248CD@gemini.denx.de>
On Friday 26 September 2008, Wolfgang Denk wrote:
> > > Am I reading this correctly that we eth_halt() and eth_init() the
> > > network interface for each and every call to NetLoop?
> >
> > Yes, it looks that way. Ripe for gutting.
>
> I didn't have much time to look into the code, so I'm just speculating
> - maybe this is needed for switching interfaces in case of errors?
Some ethernet interfaces (e.g. ppc4xx) need to get stopped after the network
transaction. Otherwise the interface will continue to DMA data to the buffers
and this could break OS booting. So please don't remove the eth_halt() after
the transaction is finished.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2008-09-26 7:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-12 19:50 [U-Boot] Inefficient code in NetLoop() ? Wolfgang Denk
2008-09-26 6:09 ` Ben Warren
2008-09-26 7:36 ` Wolfgang Denk
2008-09-26 7:55 ` Stefan Roese [this message]
2008-09-26 8:14 ` Rafal Jaworowski
2008-09-26 8:28 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809260955.59674.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.