From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
Linas Vepstas <linas@austin.ibm.com>,
"rajesh.shah@intel.com" <rajesh.shah@intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Kristen Accardi <kristen.c.accardi@intel.com>,
Muli Ben-Yehuda <muli@il.ibm.com>,
jbarnes@virtuousgeek.org, tglx@linutronix.de, hpa@zytor.com,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, Yinghai Lu <yhlu.kernel@gmail.com>
Subject: Re: [PATCH] x86, pci-hotplug, calgary / rio: fix EBDA ioremap()
Date: Sat, 27 Sep 2008 18:35:28 +0200 [thread overview]
Message-ID: <20080927163528.GD4600@elte.hu> (raw)
In-Reply-To: <48DCC403.7070302@linux.intel.com>
* Arjan van de Ven <arjan@linux.intel.com> wrote:
>>>
>>> mapping the EBDA is rather ... un-nice from that driver, so i guess
>>> you check does the right thing in flagging possible crap.
>>
>> it does:
>>
>> addr: 0x9f800
>> end: 0xaf5e7
>> p->start: 0x9f800
>> p->end: 0x9ffff
>>
>> resources are laid out like this:
>>
>> 0009f800-0009ffff : reserved
>> 000a0000-000bffff : Video RAM area
>>
>> so the driver over-maps into the Video RAM...
>
> ... and makes that uncachable (while it probably was WC before)
ah, neat angle, i did not consider that. One more entry into the '10
good reasons why ioremap-ing RAM is bad' list.
Ingo
next prev parent reply other threads:[~2008-09-27 16:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-26 1:43 [patch] ioremap sanity check to catch mapping requests exceeding the BAR sizes Suresh Siddha
2008-09-26 7:39 ` Ingo Molnar
2008-09-26 8:10 ` Yinghai Lu
2008-09-26 8:12 ` Ingo Molnar
2008-09-26 8:35 ` Ingo Molnar
2008-09-26 9:46 ` [PATCH] x86, pci-hotplug, calgary / rio: fix EBDA ioremap() Ingo Molnar
2008-09-26 11:14 ` Arjan van de Ven
2008-09-27 16:35 ` Ingo Molnar [this message]
2008-09-27 7:16 ` [patch] ioremap sanity check to catch mapping requests exceeding the BAR sizes Jeremy Fitzhardinge
2008-09-27 11:21 ` Alan Cox
2008-09-27 14:43 ` Jeremy Fitzhardinge
2008-09-27 15:09 ` Arjan van de Ven
2008-09-27 16:17 ` Jeremy Fitzhardinge
2008-09-27 16:25 ` Alan Cox
2008-09-27 19:24 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080927163528.GD4600@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=kristen.c.accardi@intel.com \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@il.ibm.com \
--cc=rajesh.shah@intel.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.