From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754008AbYI0SK6 (ORCPT ); Sat, 27 Sep 2008 14:10:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752925AbYI0SKv (ORCPT ); Sat, 27 Sep 2008 14:10:51 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:52254 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752884AbYI0SKv (ORCPT ); Sat, 27 Sep 2008 14:10:51 -0400 Date: Sat, 27 Sep 2008 20:10:42 +0200 From: Ingo Molnar To: Chris Friesen Cc: Peter Zijlstra , Linux kernel Subject: Re: [patch] sched: trivial fix for incorrect comments Message-ID: <20080927181042.GD1108@elte.hu> References: <48D3C9FF.20504@nortel.com> <20080922110049.GA5987@elte.hu> <48D91464.9010501@nortel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48D91464.9010501@nortel.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0008] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Chris Friesen wrote: > --- a/kernel/sched.c > +++ b/kernel/sched.c > @@ -298,9 +298,9 @@ static DEFINE_PER_CPU(struct cfs_rq, init_cfs_rq) ____cacheline_aligned_in_smp; > static DEFINE_PER_CPU(struct sched_rt_entity, init_sched_rt_entity); > static DEFINE_PER_CPU(struct rt_rq, init_rt_rq) ____cacheline_aligned_in_smp; > #endif /* CONFIG_RT_GROUP_SCHED */ > -#else /* !CONFIG_FAIR_GROUP_SCHED */ > +#else /* !CONFIG_USER_SCHED */ > #define root_task_group init_task_group > -#endif /* CONFIG_FAIR_GROUP_SCHED */ > +#endif /* CONFIG_USER_SCHED */ hm, these seem to be fixed already, via: | commit 9a7e0b180da21885988d47558671cf580279f9d6 | Author: Peter Zijlstra | Date: Tue Aug 19 12:33:06 2008 +0200 | | sched: rt-bandwidth fixes is all in tip/master. (or is perhaps the direction of your patch wrong?) Ingo