From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KjwKB-0000ic-5o for mharc-grub-devel@gnu.org; Sun, 28 Sep 2008 09:28:35 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KjwK9-0000hO-NZ for grub-devel@gnu.org; Sun, 28 Sep 2008 09:28:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KjwK9-0000gW-0P for grub-devel@gnu.org; Sun, 28 Sep 2008 09:28:33 -0400 Received: from [199.232.76.173] (port=39706 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KjwK8-0000gM-Sj for grub-devel@gnu.org; Sun, 28 Sep 2008 09:28:32 -0400 Received: from aybabtu.com ([69.60.117.155]:40755) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KjwK6-00079L-Mq for grub-devel@gnu.org; Sun, 28 Sep 2008 09:28:31 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1Kjw7G-0007SQ-6J for grub-devel@gnu.org; Sun, 28 Sep 2008 15:15:16 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KjwI6-0006Cp-NI for grub-devel@gnu.org; Sun, 28 Sep 2008 15:26:26 +0200 Date: Sun, 28 Sep 2008 15:26:26 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080928132626.GA23805@thorin> References: <20080823144313.GA24757@pina.cat> <20080830114315.GC16775@thorin> <20080905165932.GC5625@pina.cat> <20080927173752.GA23044@pina.cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080927173752.GA23044@pina.cat> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Warning if grub.cfg not found X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Sep 2008 13:28:34 -0000 On Sat, Sep 27, 2008 at 07:37:52PM +0200, Carles Pina i Estany wrote: > --- normal/main.c (revision 1877) > +++ normal/main.c (working copy) > @@ -230,7 +230,13 @@ > /* Try to open the config file. */ > file = grub_file_open (config); > if (! file) > - return 0; > + { This seems to include the possibility that file cannot be read simply because it's not there. Perhaps user intended so, and this shouldn't be reported as an error. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."