From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Kk40v-0003Sc-BA for mharc-grub-devel@gnu.org; Sun, 28 Sep 2008 17:41:13 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kk40t-0003Rz-Kd for grub-devel@gnu.org; Sun, 28 Sep 2008 17:41:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kk40s-0003R5-0d for grub-devel@gnu.org; Sun, 28 Sep 2008 17:41:11 -0400 Received: from [199.232.76.173] (port=56406 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kk40r-0003R2-Rj for grub-devel@gnu.org; Sun, 28 Sep 2008 17:41:09 -0400 Received: from 197.red-80-32-81.staticip.rima-tde.net ([80.32.81.197]:39676 helo=mail.pina.cat) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kk40r-0004kG-AU for grub-devel@gnu.org; Sun, 28 Sep 2008 17:41:09 -0400 Received: from pinux (60.61.221.87.dynamic.jazztel.es [87.221.61.60]) by mail.pina.cat (Postfix) with ESMTP id 88832288FBA1E for ; Sun, 28 Sep 2008 23:41:03 +0200 (CEST) Received: by pinux (Postfix, from userid 1000) id 22F937C6C; Sun, 28 Sep 2008 23:41:02 +0200 (CEST) Date: Sun, 28 Sep 2008 23:41:02 +0200 From: Carles Pina i Estany To: The development of GRUB 2 Message-ID: <20080928214102.GA5259@pina.cat> References: <20080823144313.GA24757@pina.cat> <20080830114315.GC16775@thorin> <20080905165932.GC5625@pina.cat> <20080927173752.GA23044@pina.cat> <20080928132626.GA23805@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080928132626.GA23805@thorin> User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Warning if grub.cfg not found X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Sep 2008 21:41:12 -0000 Hello, On Sep/28/2008, Robert Millan wrote: > On Sat, Sep 27, 2008 at 07:37:52PM +0200, Carles Pina i Estany wrote: > > --- normal/main.c (revision 1877) > > +++ normal/main.c (working copy) > > @@ -230,7 +230,13 @@ > > /* Try to open the config file. */ > > file = grub_file_open (config); > > if (! file) > > - return 0; > > + { > > This seems to include the possibility that file cannot be read simply because > it's not there. Perhaps user intended so, and this shouldn't be reported as > an error. Do you mean that we could change: + grub_print_error (); by "grub_print_warning"? Or the whole point (warn the user if file is not there) is incorrect? If user doesn't want a grub.cfg, he/she could "touch grub.cfg" and that's all, no? If some user is miss-configuring Grub2 (pointing to an invalid device, partition, etc.) he will prefer to read "cannot find grub.cfg" than just see a shell (it's quite confusing, or it was for me when it happened :-) ) -- Carles Pina i Estany GPG id: 0x17756391 http://pinux.info