All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i2c: add i2c reset command.
Date: Mon, 29 Sep 2008 10:45:24 +0200	[thread overview]
Message-ID: <20080929084524.A463524851@gemini.denx.de> (raw)
In-Reply-To: <48E0894D.2010101@denx.de>

Dear Heiko Schocher,

In message <48E0894D.2010101@denx.de> you wrote:
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
>  common/cmd_i2c.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c
> index ef3928e..414c888 100644
> --- a/common/cmd_i2c.c
> +++ b/common/cmd_i2c.c
> @@ -1182,6 +1182,12 @@ int do_sdram (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
>  #endif
> 
>  #if defined(CONFIG_I2C_CMD_TREE)
> +int do_i2c_res(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
> +{
> +	i2c_init (CFG_I2C_SPEED, CFG_I2C_SLAVE);
> +	return 0;
> +}

What does "res" mean? "Resource"? "resync"? "rescale"? "rescan"?

If you mean reset, then please write reset.

Also, in which way is this supposed to reset the I2C controller?

In short: which problem is this supposed to fix?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
One of the advantages of being a captain is being able to ask for ad-
vice without necessarily having to take it.
	-- Kirk, "Dagger of the Mind", stardate 2715.2

  reply	other threads:[~2008-09-29  8:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-29  7:52 [U-Boot] [PATCH] i2c: add i2c reset command Heiko Schocher
2008-09-29  8:45 ` Wolfgang Denk [this message]
2008-10-14 16:27 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080929084524.A463524851@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.