From: Lennert Buytenhek <buytenh@wantstofly.org>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: netdev@vger.kernel.org, Ram.Natarajan@Emulex.Com,
Eric Dumazet <dada1@cosmosbay.com>,
Ashish Karkare <akarkare@marvell.com>,
Nicolas Pitre <nico@cam.org>
Subject: Re: [PATCHv2 1/2] [NET] add skb_recycle_check() to enable netdriver skb recycling
Date: Mon, 29 Sep 2008 11:46:50 +0200 [thread overview]
Message-ID: <20080929094650.GA26097@xi.wantstofly.org> (raw)
In-Reply-To: <20080929053931.GB21663@2ka.mipt.ru>
On Mon, Sep 29, 2008 at 09:39:31AM +0400, Evgeniy Polyakov wrote:
> Hi Lennert.
Hi Evgeniy,
> > Doesn't it? It calls skb_release_head_state() (new function), which
> > should do that.
>
> Argh, you are right, I missed this hunk:
> -/* Free everything but the sk_buff shell. */
> -static void skb_release_all(struct sk_buff *skb)
> +static void skb_release_head_state(struct sk_buff *skb)
>
> Patches look good.
Cool, thanks for having a look.
Could you (or anyone else) try this patch on one of your boxes and
see what kind of effect it has on performance?
cheers,
Lennert
next prev parent reply other threads:[~2008-09-29 9:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-28 20:46 [PATCHv2 1/2] [NET] add skb_recycle_check() to enable netdriver skb recycling Lennert Buytenhek
2008-09-28 21:38 ` Evgeniy Polyakov
2008-09-28 21:50 ` Lennert Buytenhek
2008-09-29 5:39 ` Evgeniy Polyakov
2008-09-29 9:46 ` Lennert Buytenhek [this message]
2008-09-29 14:33 ` Evgeniy Polyakov
2008-09-30 3:08 ` Lennert Buytenhek
2008-10-02 7:17 ` Evgeniy Polyakov
2008-09-29 20:21 ` Brandeburg, Jesse
2008-09-30 2:57 ` Lennert Buytenhek
2008-10-08 1:24 ` Terry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080929094650.GA26097@xi.wantstofly.org \
--to=buytenh@wantstofly.org \
--cc=Ram.Natarajan@Emulex.Com \
--cc=akarkare@marvell.com \
--cc=dada1@cosmosbay.com \
--cc=johnpol@2ka.mipt.ru \
--cc=netdev@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.