From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Rolf Eike Beer <eike-kernel@sf-tec.de>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 01/19] pci: introduce an pci_ioremap(pdev, barnr) function
Date: Mon, 29 Sep 2008 11:26:41 -0700 [thread overview]
Message-ID: <200809291126.42753.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <20080929111558.04f27eea@infradead.org>
On Monday, September 29, 2008 11:15 am Arjan van de Ven wrote:
> On Mon, 29 Sep 2008 18:45:19 +0100
>
> Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > > > This is the same like pci_iomap(pdev, number, 0), no?
> > >
> > > Yeah... Looks like that function isn't that widely used though. Is
> > > the maxlen param really needed? Looks like the drivers that use it
> > > often pass 0 or the
> >
> > In some cases yes you do need the length.
>
> so we should have a 2nd api for those "some cases", that's ok.
Right, I'm definitely not suggesting that we don't provide a way to provide
length, but if 90+% of callers don't need it, we should probably have a
simpler API that does the bare minimum.
Jesse
next prev parent reply other threads:[~2008-09-29 18:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-28 23:36 [PATCH 01/19] pci: introduce an pci_ioremap(pdev, barnr) function Arjan van de Ven
2008-09-29 17:02 ` Rolf Eike Beer
2008-09-29 17:20 ` Jesse Barnes
2008-09-29 17:45 ` Alan Cox
2008-09-29 18:15 ` Arjan van de Ven
2008-09-29 18:26 ` Jesse Barnes [this message]
2008-10-02 18:53 ` Jesse Barnes
2008-10-02 19:05 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809291126.42753.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=eike-kernel@sf-tec.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.