From: David Brownell <david-b@pacbell.net>
To: Felipe Balbi <me@felipebalbi.com>
Cc: linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
Felipe Balbi <felipe.balbi@nokia.com>
Subject: Re: [PATCH 00/23] twl4030 patches (v3)
Date: Mon, 29 Sep 2008 13:59:34 -0700 [thread overview]
Message-ID: <200809291359.34589.david-b@pacbell.net> (raw)
In-Reply-To: <1222705669-18230-1-git-send-email-me@felipebalbi.com>
Well I can confirm that this is stuff I've seen to behave OK,
by diffing the patches against known-working versions. There
were Overo differences, and some keymap things.
Patch 0002 (don't zero pullup/pulldown configuration) is still
missing the ACK I sent when it first came though. :)
On the other hand, building against the tarball of patches
you sent gives me:
arch/arm/mach-omap2/board-overo.c:154: error: variable 'overo_usb_data' has initializer but incomplete type
arch/arm/mach-omap2/board-overo.c:155: error: unknown field 'usb_mode' specified in initializer
arch/arm/mach-omap2/board-overo.c:155: warning: excess elements in struct initializer
arch/arm/mach-omap2/board-overo.c:155: warning: (near initialization for 'overo_usb_data')
arch/arm/mach-omap2/board-overo.c:162: warning: initialization from incompatible pointer type
make[1]: *** [arch/arm/mach-omap2/board-overo.o] Error 1
make: *** [arch/arm/mach-omap2] Error 2
make: *** Waiting for unfinished jobs....
CC arch/arm/plat-omap/i2c.o
---
arch/arm/mach-omap2/board-overo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/arm/mach-omap2/board-overo.c
+++ b/arch/arm/mach-omap2/board-overo.c
@@ -151,7 +151,7 @@ static struct twl4030_gpio_platform_data
.irq_end = TWL4030_GPIO_IRQ_END,
};
-static struct twl4030_usb_platform_data overo_usb_data = {
+static struct twl4030_usb_data overo_usb_data = {
.usb_mode = T2_USB_MODE_ULPI,
};
next parent reply other threads:[~2008-09-29 20:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1222705669-18230-1-git-send-email-me@felipebalbi.com>
2008-09-29 20:59 ` David Brownell [this message]
2008-09-29 21:04 ` [PATCH 00/23] twl4030 patches (v3) Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809291359.34589.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.