From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH 3/5] [RFC] ALSA ASOC Adds DSP DAI format support for platform driver Date: Mon, 29 Sep 2008 14:15:40 +0300 Message-ID: <20080929141540.e6ae8ead.jarkko.nikula@nokia.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.nokia.com ([192.100.122.233]:64896 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751609AbYI2LQa (ORCPT ); Mon, 29 Sep 2008 07:16:30 -0400 In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: ext Arun KS Cc: "linux-omap@vger.kernel.org List" , alsa-devel@vger.kernel.org, felipe.balbi@nokia.com On Mon, 29 Sep 2008 15:20:12 +0530 "ext Arun KS" wrote: > Enables DSP DAI format for mcbsp in omap platform driver > > Signed-off-by: Arun KS > --- > sound/soc/omap/omap-mcbsp.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c > index 3a4cc4b..1c024aa 100644 > --- a/sound/soc/omap/omap-mcbsp.c > +++ b/sound/soc/omap/omap-mcbsp.c > @@ -292,6 +292,12 @@ static int omap_mcbsp_dai_set_dai_fmt(struct > snd_soc_dai *cpu_dai, > regs->rcr2 |= RDATDLY(1); > regs->xcr2 |= XDATDLY(1); > break; > + case SND_SOC_DAIFMT_DSP_A: > + /* 0-bit data delay */ > + regs->rcr2 |= RDATDLY(0); > + regs->xcr2 |= XDATDLY(0); > + break; > + > default: I think this is not enough. The word clock length equals to one BCLK cycle in DSP mode. Not n channel bit BCLK cycles like in I2S. Jarkko