From: Oleg Nesterov <oleg@tv-sign.ru>
To: Krishna Kumar <krkumar2@in.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [REV2: PATCH 2/2]: workqueue: Modify some users to use the new API
Date: Mon, 29 Sep 2008 18:45:30 +0400 [thread overview]
Message-ID: <20080929144530.GC85@tv-sign.ru> (raw)
In-Reply-To: <20080929070328.7386.70911.sendpatchset@localhost.localdomain>
On 09/29, Krishna Kumar wrote:
>
> Modify some users to use the new API.
Looks good, but I don't understand this code.
Krishna, I'd suggest you to send each change in a separate patch with
the maintainer cc'ed.
And please don't forget to mention that update() != cancel() + queue().
Otherwise maintainer can miss this fact.
Oleg.
prev parent reply other threads:[~2008-09-29 14:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 7:03 [REV2: PATCH 0/2] workqueue: Two API's to update delayed works quickly Krishna Kumar
2008-09-29 7:03 ` [REV2: PATCH 1/2]: workqueue: Implement the kernel API Krishna Kumar
2008-09-29 14:27 ` Oleg Nesterov
2008-09-30 11:08 ` Krishna Kumar2
2008-09-30 13:15 ` Oleg Nesterov
2008-09-29 7:03 ` [REV2: PATCH 2/2]: workqueue: Modify some users to use the new API Krishna Kumar
2008-09-29 14:45 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080929144530.GC85@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=krkumar2@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.