All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Ingo Molnar <mingo@elte.hu>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	"Frank Ch. Eigler" <fche@redhat.com>,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: [PATCH] Markers : documentation fix teardown
Date: Mon, 29 Sep 2008 11:10:34 -0400	[thread overview]
Message-ID: <20080929151034.GG11245@Krystal> (raw)
In-Reply-To: <20080929082722.GB18663@elte.hu>

Document the need for a marker_synchronize_unregister() before the end of exit()
to make sure every probe callers have exited the non preemptible section and
thus are not executing the probe code anymore.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
CC: Ingo Molnar <mingo@elte.hu>
CC: Rusty Russell <rusty@rustcorp.com.au>
CC: akpm@linux-foundation.org
CC: "Frank Ch. Eigler" <fche@redhat.com>
---
 Documentation/markers.txt |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Index: linux-2.6-lttng/Documentation/markers.txt
===================================================================
--- linux-2.6-lttng.orig/Documentation/markers.txt	2008-07-31 09:11:13.000000000 -0400
+++ linux-2.6-lttng/Documentation/markers.txt	2008-07-31 09:20:57.000000000 -0400
@@ -50,10 +50,12 @@ Connecting a function (probe) to a marke
 to call) for the specific marker through marker_probe_register() and can be
 activated by calling marker_arm(). Marker deactivation can be done by calling
 marker_disarm() as many times as marker_arm() has been called. Removing a probe
-is done through marker_probe_unregister(); it will disarm the probe and make
-sure there is no caller left using the probe when it returns. Probe removal is
-preempt-safe because preemption is disabled around the probe call. See the
-"Probe example" section below for a sample probe module.
+is done through marker_probe_unregister(); it will disarm the probe.
+marker_synchronize_unregister() must be called before the end of the module exit
+function to make sure there is no caller left using the probe. This, and the
+fact that preemption is disabled around the probe call, make sure that probe
+removal and module unload are safe. See the "Probe example" section below for a
+sample probe module.
 
 The marker mechanism supports inserting multiple instances of the same marker.
 Markers can be put in inline functions, inlined static functions, and
-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

  parent reply	other threads:[~2008-09-29 15:10 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-29  8:00 [PATCH] markers: fix unregister bug and reenter bug Lai Jiangshan
2008-09-29  8:27 ` Ingo Molnar
2008-09-29 15:03   ` Mathieu Desnoyers
2008-09-29 15:05   ` [PATCH] Markers : marker_synchronize_unregister() Mathieu Desnoyers
2008-09-30  1:47     ` Lai Jiangshan
     [not found]     ` <20081002235650.43ca075c.akpm@linux-foundation.org>
2008-10-03 15:52       ` [PATCH] Markers synchronize unregister static inline Mathieu Desnoyers
2008-10-03 17:31         ` Ingo Molnar
2008-09-29 15:06   ` [PATCH] RCU read sched Mathieu Desnoyers
2008-09-30 10:08     ` Ingo Molnar
2008-09-30 13:10       ` Paul E. McKenney
2008-09-30 13:10     ` Paul E. McKenney
2008-09-29 15:08   ` [PATCH] Markers use rcu_read_lock_sched() Mathieu Desnoyers
2008-09-30 10:13     ` Ingo Molnar
2008-09-29 15:09   ` [PATCH] Markers : probe example fix teardown Mathieu Desnoyers
2008-09-29 15:10   ` Mathieu Desnoyers [this message]
2008-09-29 15:11   ` [PATCH] sputrace : use marker_synchronize_unregister() Mathieu Desnoyers
2008-09-29 15:11     ` Mathieu Desnoyers
2008-09-29 15:13     ` Christoph Hellwig
2008-09-29 15:13       ` Christoph Hellwig
2008-09-30  0:28     ` Jeremy Kerr
2008-09-30  0:28       ` Jeremy Kerr
2008-09-30  9:55       ` Ingo Molnar
2008-09-30  9:55         ` Ingo Molnar
2008-09-30 11:22         ` [Cbe-oss-dev] " Jeremy Kerr
2008-09-30 11:22           ` Jeremy Kerr
2008-09-30 11:30           ` Ingo Molnar
2008-09-30 11:30             ` Ingo Molnar
2008-09-30 11:34             ` Jeremy Kerr
2008-09-30 11:34               ` Jeremy Kerr
2008-09-29 15:03 ` [PATCH] markers: fix unregister bug and reenter bug Mathieu Desnoyers
2008-09-30  1:40   ` Lai Jiangshan
2008-09-30  3:38     ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080929151034.GG11245@Krystal \
    --to=mathieu.desnoyers@polymtl.ca \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=fche@redhat.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.