From: Felipe Balbi <me@felipebalbi.com>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: linux-omap@vger.kernel.org,
David Brownell <dbrownell@users.sourceforge.net>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 15/22] twl4030: move pm_power_off initialization to twl4030-core.c
Date: Mon, 29 Sep 2008 18:42:52 +0300 [thread overview]
Message-ID: <20080929154251.GG30555@frodo> (raw)
In-Reply-To: <1222694079-16289-16-git-send-email-felipe.balbi@nokia.com>
On Mon, Sep 29, 2008 at 04:14:32PM +0300, Felipe Balbi wrote:
> We don't really need a whole new driver just for initializing
> one pointer. Move it to core initialization.
I'll refactor this patch. We (me and Dave) agreed this code doesn't
belong to twl4030-core.c. For now, let's keep it the way it is and we
touch this when we go for twl4030-power.c and twl4030-pwrirq.c rework.
Resending the series soon.
--
balbi
next prev parent reply other threads:[~2008-09-29 15:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 13:14 [PATCH 00/22] twl4030 patches Felipe Balbi
2008-09-29 13:14 ` [PATCH 01/22] twl4030: fix potential null pointer dereference Felipe Balbi
2008-09-29 13:14 ` [PATCH 02/22] twl4030-gpio: Remove default pullup enable/disable of GPIO Felipe Balbi
2008-09-29 13:14 ` [PATCH 03/22] i2c: clean add_children a bit Felipe Balbi
2008-09-29 13:14 ` [PATCH 04/22] i2c: move twl4030_keypad to new style registration Felipe Balbi
2008-09-29 13:14 ` [PATCH 05/22] i2c: move twl4030-usb to platform_device Felipe Balbi
2008-09-29 13:14 ` [PATCH 06/22] i2c: twl4030-usb: add 'vbus' sysfs file Felipe Balbi
2008-09-29 13:14 ` [PATCH 07/22] twl4030 gpio platform data Felipe Balbi
2008-09-29 13:14 ` [PATCH 08/22] twl4030 uses gpiolib Felipe Balbi
2008-09-29 13:14 ` [PATCH 09/22] i2c: move twl4030-madc to new registration style Felipe Balbi
2008-09-29 13:14 ` [PATCH 10/22] minor twl4030-core cleanups Felipe Balbi
2008-09-29 13:14 ` [PATCH 11/22] provide detailed diagnostics in add_children() Felipe Balbi
2008-09-29 13:14 ` [PATCH 12/22] move twl4030-gpio to drivers/gpio Felipe Balbi
2008-09-29 13:14 ` [PATCH 13/22] i2c: added a few missing gotos to add_children() Felipe Balbi
2008-09-29 13:14 ` [PATCH 14/22] minor irq-related cleanups Felipe Balbi
2008-09-29 13:14 ` [PATCH 15/22] twl4030: move pm_power_off initialization to twl4030-core.c Felipe Balbi
2008-09-29 13:14 ` [PATCH 16/22] i2c: switch twl4030-usb to use a resource for irq Felipe Balbi
2008-09-29 13:14 ` [PATCH 17/22] Move I2C driver model init earlier in the boot sequence Felipe Balbi
2008-09-29 13:14 ` [PATCH 18/22] i2c: minor cleanups to twl4030-pwrbutton.c Felipe Balbi
2008-09-29 13:14 ` [PATCH 19/22] twl4030-gpio irq_chip.set_type Felipe Balbi
2008-09-29 13:14 ` [PATCH 20/22] twl4030-gpio: remove legacy irq triggering calls and user Felipe Balbi
2008-09-29 13:14 ` [PATCH 21/22] twl4030-gpio: irq and other cleanup Felipe Balbi
2008-09-29 13:14 ` [PATCH 22/22] twl4030-core: portability updates Felipe Balbi
2008-09-29 15:42 ` Felipe Balbi [this message]
2008-10-01 6:53 ` [PATCH 14/22] minor irq-related cleanups Pakaravoor, Jagadeesh
2008-09-29 15:02 ` [PATCH 05/22] i2c: move twl4030-usb to platform_device Steve Sakoman
2008-09-29 15:43 ` Felipe Balbi
2008-09-29 18:39 ` [PATCH 00/22] twl4030 patches David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080929154251.GG30555@frodo \
--to=me@felipebalbi.com \
--cc=dbrownell@users.sourceforge.net \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.